Add config tests for DeepSeek V3 architecture adapter#1531
Merged
jlarson4 merged 1 commit intoJul 22, 2026
Conversation
Collaborator
|
Looks great! Thank you for putting this together @SanjidMzi! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1302.
This pr adds unit tests for
DeepSeekV3ArchitectureAdaptercovering the config flags itsets, the component-mapping structure and HF module paths, the MLA attention
submodule mapping, and the (empty) weight-conversion set.
V3 differs from V2 at the unit level: V3 always compresses Q via
the two-stage LoRA path (that's why there is no direct
q_projfallback and everyattention projection is required),
q_a_layernormis an RMSNorm rather than aplain component, and the router
gateis bridged as an optional component.Behavioural coverage (forward pass, hook firing) already lives in
tests/integration/model_bridge/test_deepseek_adapter.py; these testscomplement it at the unit tier, following the same pattern as the existing
test_deepseek_v2_adapter.py.make format,uv run mypy ., andmake unit-testall pass locally.