Comment cleanup jul 26#1541
Merged
Merged
Conversation
granite_moe had substantive test coverage, but embedded inside test_granite_adapter.py rather than in its own file — inconsistent with every other architecture listed in #1302 (including granite_moe_hybrid), which each get a dedicated test_<name>_adapter.py. Moves that coverage into test_granite_moe_adapter.py and adds the one piece that was missing: an explicit config-flag test class (GraniteMoe doesn't override config setup, so it inherits dense Granite's flags, but nothing asserted that directly before). test_granite_adapter.py goes back to covering only GraniteArchitectureAdapter, matching its own docstring.
…#1521) * feat: add RWKV-7 (Goose) TransformerBridge adapter (RWKV7ForCausalLM) Signed-off-by: Mukund Pandey <mukund.pandey@gmail.com> * refactor: use OpaqueBlockBridge for RWKV-7; introduce OpaqueBlockBridge base class Signed-off-by: Mukund Pandey <mukund.pandey@gmail.com> * added hook_out_is_single_residual_stream default to OpaqueBlockBridge * style: apply black formatting to opaque_block, ssm_block, __init__ Signed-off-by: Mukund Pandey <mukund.pandey@gmail.com> * style: fix import order in generalized_components/__init__.py (isort) Signed-off-by: Mukund Pandey <mukund.pandey@gmail.com> * style: fix import order in generalized_components/__init__.py (isort) Signed-off-by: Mukund Pandey <mukund.pandey@gmail.com> * style: fix import order in generalized_components/__init__.py (isort) Signed-off-by: Mukund Pandey <mukund.pandey@gmail.com> * refactor: replace SSM2MixerBridge with GeneralizedComponent for RWKV-7 attn/ffn sublayers Signed-off-by: Mukund Pandey <mukund.pandey@gmail.com> * style: fix black formatting in generate_report.py Signed-off-by: Mukund Pandey <mukund.pandey@gmail.com> --------- Signed-off-by: Mukund Pandey <mukund.pandey@gmail.com> Co-authored-by: jlarson4 <jonahalarson@comcast.net>
* Add RavenForCausalLM (Huginn) TransformerBridge adapter Adds a TransformerBridge architecture adapter for RavenForCausalLM (tomg-group-umd/huginn-0125), a depth-recurrent decoder with a prelude / weight-tied recurrent core / coda structure, resolving #1469. - raven.py delegates the recurrence to the remote-code HF forward and maps the three physical block lists (prelude / core_block / coda) via SSMBlockBridge, with combined-QKV native attention and a gated MLP. Sets applicable_phases=[] (a random initial latent state and post-residual sandwich norms diverge from the verify_models phases) and supports_fold_ln=False (ln_f is reused mid-network). prepare_loading patches Huginn's remote code for transformers v5 (tied-weights-keys dict form + a weight re-init guard). - Registers in the adapter factory, the model registry (canonical author and description) and supported_models.json; surfaces the recurrence-shape config via both _HF_PASSTHROUGH_ATTRS lists. - Adds synthetic-config unit tests and CI-gated integration tests. * fix: pass num_steps as int to iterate_forward (0-d tensor has no len) * fix: remove unused torch import and use setattr for dynamic cfg attrs * style: apply black formatting to raven.py Signed-off-by: Mukund Pandey <mukund.pandey@gmail.com> * refactor: introduce OpaqueBlockBridge; use it for Raven instead of SSMBlockBridge Signed-off-by: Mukund Pandey <mukund.pandey@gmail.com> * style: apply black formatting to opaque_block, ssm_block, __init__ Signed-off-by: Mukund Pandey <mukund.pandey@gmail.com> * style: fix import order in generalized_components/__init__.py (isort) Signed-off-by: Mukund Pandey <mukund.pandey@gmail.com> * fix: strip dead hook_q/k/v aliases from Raven AttentionBridge Raven uses a combined Wqkv projection (no separate q/k/v submodules), so AttentionBridge's default hook_q/hook_k/hook_v aliases (which target q.hook_out / k.hook_out / v.hook_out) are unresolvable. The upstream test_every_hook_alias_resolves_to_hookpoint audit catches these as 9 dead aliases across prelude / core_block / coda. Strip them by setting an instance-level hook_aliases that omits those three keys, leaving only the aliases that have real HookPoint targets. Signed-off-by: Mukund Pandey <mukund.pandey@gmail.com> * chore: merge upstream/dev — add RWKV-7 passthrough attrs and registry entry Brings in the RWKV-7 additions from #1521 that landed in dev: - _bridge_builder.py: added RWKV-7 passthrough attrs (num_heads, value_dim, decay/gate/a/v_low_rank_dim, norm_first, norm_bias, fuse_norm, attn_mode, hidden_act) - generate_report.py: added RWKV7ForCausalLM description entry Signed-off-by: Mukund Pandey <mukund.pandey@gmail.com> --------- Signed-off-by: Mukund Pandey <mukund.pandey@gmail.com>
The Tracr demo passes output_label="reverse", but Tracr builds labels as
f"{name}_{unique_id}", so the compiled expression's residual labels are
reverse_1:* and the demo raises ValueError at the state-dict cell. Pass
reverse.label instead of hardcoding the name, and correct the same wrong
label shape in the unit-test fixture (real Tracr never emits "reverse:1")
and in the infer_tracr_output_label docstring example.
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…g models (#1519) * Add TransformerLens pretrain bridge adapter * Add TransformerLens pretrain bridge adapter
…lue injection to bridge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaning up overly verbose comments