Fit the Studio gulp heap inside the builder - #184
Conversation
Deploy 43b800fb cleared the clone and OOMed again, with a different message, and the difference is the diagnosis. MarkCompactCollector at the default ceiling is V8 declining at its own limit, so raising it was the right lever. NewSpace::EnsureCurrentCapacity at 12288MiB is V8 asking the OS for memory and being refused: the ceiling sat above what the builder can back, so instead of collecting harder it grew until the container said no. Raising this is not monotonic, and 12288 was worse than the default. Lowered to 6144 to sit under a host that could not back 12G, with the reasoning recorded so the next reader moves in the right direction rather than reaching for a bigger number. Still a measurement and not a derivation: the builder does not report its size, and STUDIO_NODE_HEAP_MB remains the knob.
|
Warning Review limit reached
Next review available in: 58 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adjusts the default Node/V8 heap ceiling used during the CommonPlace Studio server build so the Studio gulp compile is less likely to OOM on the Railway builder, and records the observed failure-mode reasoning in-line for future tuning.
Changes:
- Lowers the default
STUDIO_NODE_HEAP_MBfallback from12288to6144. - Expands the inline comment explaining why “bigger heap” can be worse on constrained builders (V8 ceiling vs OS refusal).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Deploy
43b800fbcleared the clone (the #183 revert worked) and OOMed again in the Studio stage, with a different message, and the difference is the whole diagnosis.MarkCompactCollector: young object promotion failedat the default ceiling: V8 declining at its own configured limit, so raising the limit was the right lever.43b800fb, at 12288MiB, sawNewSpace::EnsureCurrentCapacity Allocation failed: V8 asking the OS for memory and being refused. The ceiling was above what the builder can back, so instead of collecting harder V8 grew until the container said no.Raising this is therefore not monotonic, and 12288 was worse than the default. Lowered to 6144, with the reasoning recorded so the next reader moves in the right direction rather than reaching for a bigger number.
Still a measurement rather than a derivation: the builder does not report its size.
STUDIO_NODE_HEAP_MBremains the knob.Validation: shellcheck clean. The compile is still unproven; this build is the next oracle.