Skip to content

fix(studio): skip mangling on unminified reh-web (CS-001) - #186

Merged
Travis-Gilbert merged 1 commit into
mainfrom
fix/studio-skip-mangler-on-unminified
Aug 4, 2026
Merged

fix(studio): skip mangling on unminified reh-web (CS-001)#186
Travis-Gilbert merged 1 commit into
mainfrom
fix/studio-skip-mangler-on-unminified

Conversation

@Travis-Gilbert

Copy link
Copy Markdown
Owner

Summary

  • Deploy 7c2690ab after Build the Studio server unminified #185 still OOM'd: vscode-reh-web-linux-x64 (no -min) still starts with compileBuildWithManglingTask.
  • Add patch 0002-reh-web-unminified-skip-mangler.patch so unminified reh-web uses compileBuildWithoutManglingTask; -min keeps mangling + patch 0001.
  • Update LEDGER, build.sh comments, and FOLLOW-UP-CODE-SERVE-WEB CS-001/003 status.

Test plan

  • packaging/commonplace-studio/scripts/ledger-gate.sh passes (done locally)
  • Railway commonplace-workspace rebuild after merge: studio-server stage completes; /opt/commonplace/studio-server/bin/commonplace-studio-server exists
  • Run smoke-server.sh against the image artifact (CS-002)
  • Keep IDE_HOST=code-server until CS-007 flip

Dropping -min still ran compileBuildWithManglingTask and OOM'd Railway
deploy 7c2690ab. Route unminified vscode-reh-web through upstream's
compile-build-without-mangling path (patch 0002) so CS-001 can finish.
Copilot AI lite review requested due to automatic review settings August 4, 2026 21:00
@Travis-Gilbert
Travis-Gilbert merged commit 52ec913 into main Aug 4, 2026
1 check passed
@ecc-tools

ecc-tools Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Travis-Gilbert, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 5 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7ccf82ac-c004-44b9-b2d2-3fe9c08096e0

📥 Commits

Reviewing files that changed from the base of the PR and between 50fa24f and 5ec7c1f.

📒 Files selected for processing (5)
  • docs/plans/ide-substrate-wire/FOLLOW-UP-CODE-SERVE-WEB.md
  • packaging/commonplace-studio/LEDGER.md
  • packaging/commonplace-studio/patches/0002-reh-web-unminified-skip-mangler.patch
  • packaging/commonplace-studio/patches/README.md
  • packaging/commonplace-studio/scripts/build.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses repeated OOM failures when building the unminified vscode-reh-web-* Studio server artifact by ensuring the unminified reh-web build path skips the private-field mangling step, while keeping the minified (-min) path mangled.

Changes:

  • Route unminified vscode-reh-web-* gulp tasks through compileBuildWithoutManglingTask via a new patch (0002), while keeping -min on compileBuildWithManglingTask.
  • Update Studio patch documentation (patch queue README + patch ledger) to reflect the new patch and rationale.
  • Update build script comments and the ide-substrate-wire follow-up plan status to capture the incident context and current CS-001/CS-003 state.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packaging/commonplace-studio/scripts/build.sh Updates server build commentary to reflect why unminified reh-web must also skip mangling (via patch 0002).
packaging/commonplace-studio/patches/README.md Documents the patch queue as non-empty and lists both build-only patches and their purpose.
packaging/commonplace-studio/patches/0002-reh-web-unminified-skip-mangler.patch Adds patch to conditionally skip mangling for unminified reh-web gulp tasks.
packaging/commonplace-studio/LEDGER.md Adds a second ledger entry documenting the new patch and updates patch count.
docs/plans/ide-substrate-wire/FOLLOW-UP-CODE-SERVE-WEB.md Updates plan status notes/checklist to reflect the new build scar and patch 0002.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +73 to +75
not an extension capability. Raising `--max-old-space-size` was tried three
times (default, 12288, 6144, then unminified with 8192 from npm's gulp script)
and only moved the abort. The mangler is the peak.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants