fix(studio): skip mangling on unminified reh-web (CS-001) - #186
Conversation
Dropping -min still ran compileBuildWithManglingTask and OOM'd Railway deploy 7c2690ab. Route unminified vscode-reh-web through upstream's compile-build-without-mangling path (patch 0002) so CS-001 can finish.
|
ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR. |
|
Warning Review limit reached
Next review available in: 5 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR addresses repeated OOM failures when building the unminified vscode-reh-web-* Studio server artifact by ensuring the unminified reh-web build path skips the private-field mangling step, while keeping the minified (-min) path mangled.
Changes:
- Route unminified
vscode-reh-web-*gulp tasks throughcompileBuildWithoutManglingTaskvia a new patch (0002), while keeping-minoncompileBuildWithManglingTask. - Update Studio patch documentation (patch queue README + patch ledger) to reflect the new patch and rationale.
- Update build script comments and the ide-substrate-wire follow-up plan status to capture the incident context and current CS-001/CS-003 state.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packaging/commonplace-studio/scripts/build.sh | Updates server build commentary to reflect why unminified reh-web must also skip mangling (via patch 0002). |
| packaging/commonplace-studio/patches/README.md | Documents the patch queue as non-empty and lists both build-only patches and their purpose. |
| packaging/commonplace-studio/patches/0002-reh-web-unminified-skip-mangler.patch | Adds patch to conditionally skip mangling for unminified reh-web gulp tasks. |
| packaging/commonplace-studio/LEDGER.md | Adds a second ledger entry documenting the new patch and updates patch count. |
| docs/plans/ide-substrate-wire/FOLLOW-UP-CODE-SERVE-WEB.md | Updates plan status notes/checklist to reflect the new build scar and patch 0002. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| not an extension capability. Raising `--max-old-space-size` was tried three | ||
| times (default, 12288, 6144, then unminified with 8192 from npm's gulp script) | ||
| and only moved the abort. The mangler is the peak. |
Summary
7c2690abafter Build the Studio server unminified #185 still OOM'd:vscode-reh-web-linux-x64(no-min) still starts withcompileBuildWithManglingTask.0002-reh-web-unminified-skip-mangler.patchso unminified reh-web usescompileBuildWithoutManglingTask;-minkeeps mangling + patch 0001.Test plan
packaging/commonplace-studio/scripts/ledger-gate.shpasses (done locally)commonplace-workspacerebuild after merge: studio-server stage completes;/opt/commonplace/studio-server/bin/commonplace-studio-serverexistssmoke-server.shagainst the image artifact (CS-002)IDE_HOST=code-serveruntil CS-007 flip