Optimize parameter drawing; give nav controllers the same behaviour as tweak#197
Merged
Conversation
sastraxi
commented
Jul 10, 2026
sastraxi
commented
Collaborator
- we now draw both filled and unfilled parameter graphs once and then blit only the dirty part
- volume now gets 128 steps, just like MIDI, instead of 256 (might want to undo this)
- the nav encoder now uses acceleration, but only in the parameter menu -- it now acts the same way as tweak
rreichenbach
approved these changes
Jul 10, 2026
rreichenbach
left a comment
rreichenbach
left a comment
Collaborator
There was a problem hiding this comment.
That feels nice. Acceleration when you need it, fine tuning when you don't.
Collaborator
Author
|
@rreichenbach what do you think about the # of detents on the volume? Would you like more precision or does the speed feel good? |
# Conflicts: # GUIDE.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.