fix(github-action): fetch tags in ifReleaseCommit to not re-release already released commit#163
Merged
Merged
Conversation
…lready released commit
Coverage Report for CI Build 28785949201Coverage decreased (-4.4%) to 59.875%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
Dispatching the release workflow (e.g. a manual release via
workflow_dispatch) while the branch HEAD is an already releasedchore(release):commit misdetects the context asreleaseinstead ofpull-request.actions/checkoutproduces a shallow clone without tags by default, andifReleaseCommitverifies the release tag only locally (git rev-parse --verify). The tag for the current version is not found in the clone, so the commit is treated as a fresh release commit. The release flow then re-runs for the already published version and fails on publish:Reproduced in real conditions: https://github.com/TrigenSoftware/dummy/actions/runs/28784646035
The fix
ifReleaseCommitnow fetches tags from the remote before checking them (same as thetagandmaintenanceBranchsteps do). The fetch is skipped when the commit message is not a release commit, and indryRunmode.Added unit tests for
ifReleaseCommitreproducing the scenario with a real--depth 1 --no-tagsclone.🤖 Generated with Claude Code