Core/Spells: Fix DynObject AoE effects for invisible targets e.g. Flare (thx to kandera) closes #3179

[ghost]

Description

Currently Flare (Spell-ID: 1543) does not work for invisible targets. Invisible targets can move inside the Flare effect without being detected.

This patch fixes it, because the searcher checking for targets does not pass the SpellInfo to the IsValidAttackTarget right now, leading to wrong results.

Revisions

Trinity: f0f68f1
Database: TDB rev. 46

Special thanks to Kandera for function variable change suggestions. :)

[joschiwald]

there are some more (same) problems for spells with SPELL_EFFECT_APPLY_AREA_AURA_XXX, is it also fixed? or maybe there is a proper solution?

[Subv]

Object::ToDynObject()

[ghost]

@Subv: I searched through code and there is no function like that, since DynObject casting is only used at few places.

@joschiwald: This one provides SpellInfo to the IsValidAttackTarget function for DynObjects, might also have other positive effects, than that one described in issue - feel free to test and give feedback. ^^

[johndays]

When the mages comes invisible, you can't mass dispel the invisible buff, in way to pull to visibile.

[ghost]

@johndays : This seems to be unrelated to the issue described here. This one here is dealing with dynobjects and spells, not with spells in general.

[johndays]

Thanks for the answer @Elron103 ,

I know, but it's possible to do some work in GridNotifiers.h in way to allow aoes effects affect invisible auras?

Good Easter.

[ghost]

@johndays : I am not sure, but it might be related.

First of all you should check the spellcast itsself, how it selects targets and so on. If the target selection points to a deeper issue in the grid notifiers, changes there could become necessary.

[johndays]

I searched a lot, but it's hard to understand, only differences that i saw between SPELL_AURA_MOD_STEALTH and SPELL_AURA_MOD_INIVISIBILITY are :

In unit.cpp SPELL_AURA_MOD_STEALH has this :

 bool InitTriggerAuraData(){
       //some code here
       isTriggerAura[SPELL_AURA_MOD_STEALTH] = true;
       //some code here
       isAlwaysTriggeredAura[SPELL_AURA_MOD_STEALTH] = true;
 } 

But it's really hard to understand if i'm searching in good way, because i don't really know if the problem is in the aura SPELL_AURA_MOD_INVISIBILITY or if it's in somewhere else. Tried to search the effects of invisibility spell in wowhead, but without result, we have this :

http://old.wowhead.com/spell=66

Effect #3 Unknown Effect (Effect #0)
Value: 100

I just did the compare between this auras, because they are similar, not in this Core, but in retail. Both of them must hide the caster, and both of them, will show the caster when he's affected by aoe spells.

[ghost]

You could try https://github.com/TrinityCore/spellwork_cs

Spell analysis tool, based on DBC data, nice tool created by TC devs. :)

[johndays]

Thanks, i will search for it!

Really nice tool, well i saw this atrr in invisibility spell,

AttributesEx3: 0x40000000 (SPELL_ATTR3_DONT_DISPLAY_RANGE) or this , that stealth have and invisibility not:

Proc flag 0x000A22A8, chance = 100, charges - 1

03 Taken damage from melee strike hit
05 Taken damage by Spell that use melee weapon
07 Taken damage from ranged attack
09 Taken damage by Spell that use ranged weapon
13 Taken negative spell hit
17 Taken magic spell damage

19 Taken periodic damage

Could be this the problem?