Fix PathPlanner trajectory logging in sim#193
Merged
Conversation
Store the active path in a field and log it every periodic() rather than calling Logger.recordOutput directly from the PathPlanner callback. This ensures the output is recorded within AdvantageKit's logging window and persists the last trajectory in AdvantageScope after the path ends. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lastTrajectoryfield (updated by the callback) instead of callingLogger.recordOutputdirectly from the callbackOdometry/Trajectoryeveryperiodic()loop for AdvantageKit compatibilitylastTrajectorywhen the incoming path is non-empty, so the plot persists in AdvantageScope after the path command endssetLogTargetPoseCallback/Odometry/TrajectorySetpointTest plan
Odometry/Trajectoryappears in AdvantageScope🤖 Generated with Claude Code