fix: remove activePtyPath short-circuit that blocked pty respawn

[matiaspalmac]

Changes

Removes the activePtyPath.current short-circuit in Terminal.tsx. Under React Strict Mode (default in dev), the ref was set at the top of the PTY effect before any async work ran. If the Strict Mode synthetic unmount fired before spawn_pty completed, the remount saw activePtyPath.current === targetPath and skipped setupPty entirely, leaving the backend PTY unspawned and the terminal blank.

The optimization was trying to avoid redundant respawns when deps fire with the same path, but:

• React already bails out of effects when primitive deps are unchanged (Object.is), so the additional guard rarely helps.
• kill_pty + spawn_pty is cheap — dropping the old state and spawning a fresh shell at the same path is fine for the cases that would slip through.
• The guard caused a real, reproducible bug in dev.

Removed the activePtyPath ref and the two lines that read/wrote it. Everything else (listener lifecycle, fit() before spawn, passing rows/cols to spawn_pty) is unchanged.

Issues

• fix [Bug]: Terminal stays empty and does not open at folder path on first attempt #28

[Copilot]

Pull request overview

Fixes a dev-only React Strict Mode race where the Terminal PTY session could fail to spawn on first open (issue #28) by removing an effect-level short-circuit that prevented setupPty() from running after a Strict Mode remount.

Changes:

• Removed activePtyPath ref used to track the “last spawned” path.
• Removed the early-return guard that skipped PTY setup when targetPath matched the ref.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.