Skip to content

fix: remove activePtyPath short-circuit that blocked pty respawn #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmaxdev merged 1 commit into from
Apr 19, 2026
Merged

fix: remove activePtyPath short-circuit that blocked pty respawn #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions apps/desktop/src/components/Terminal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ const Terminal: React.FC = () => {
const xtermRef = useRef<Xterm | null>(null);
const fitAddonRef = useRef<FitAddon | null>(null);
const initialized = useRef(false);
const activePtyPath = useRef<string | null | undefined>(undefined); // tracks last spawned path

// 1. Initialize Xterm once on mount
useEffect(() => {
Expand Down Expand Up @@ -97,10 +96,6 @@ const Terminal: React.FC = () => {

const targetPath = terminalPath || rootPath || undefined;

// Skip if we're already running a PTY for this exact path
if (activePtyPath.current !== undefined && activePtyPath.current === targetPath) return;
activePtyPath.current = targetPath ?? null;

let isCanceled = false;
let unlisten: (() => void) | undefined;

Expand Down
Loading