Skip to content

fix: gtm issues#80

Merged
rongquan1 merged 2 commits into
developfrom
feat/fix-gtm-issues
Jun 30, 2026
Merged

fix: gtm issues#80
rongquan1 merged 2 commits into
developfrom
feat/fix-gtm-issues

Conversation

@manishdex25

@manishdex25 manishdex25 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Corrected transaction outcome tracking so beneficiary endorsement events now reflect the proper action state.
  • Chores
    • Added support for a global dataLayer value, improving compatibility with tracking and analytics tools.

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1bf01c9c-50a6-4a1f-94bd-2f49de5ee72f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/fix-gtm-issues

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@manishdex25 manishdex25 requested a review from rongquan1 June 29, 2026 10:18

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/types/declaration.d.ts`:
- Line 23: The Window.dataLayer global is declared inconsistently across the
type definitions, so remove the duplicate declaration in the declaration file or
update it to match the existing GTMEvent[] augmentation used by analytics. Make
sure the only remaining Window augmentation for dataLayer comes from the shared
analytics typing so both declarations resolve to the exact same array type.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 13e9fda9-9de8-4147-b908-fc22a757dd00

📥 Commits

Reviewing files that changed from the base of the PR and between 99a44b6 and a255fa7.

📒 Files selected for processing (2)
  • src/components/AssetManagementPanel/AssetManagementApplication/index.tsx
  • src/types/declaration.d.ts

Comment thread src/types/declaration.d.ts Outdated
@rongquan1 rongquan1 merged commit baa28ac into develop Jun 30, 2026
5 checks passed
@rongquan1 rongquan1 deleted the feat/fix-gtm-issues branch June 30, 2026 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants