fix: remove did verification for issuer identity

[pennhan-dex]

Summary

Remove Issuer Identity verification using DID method.

Changes

Removed OpenAttestationDidIdentityProof from verifier
Updated affected unit tests

Summary by CodeRabbit

• Refactor

  • Removed DID-based issuer identity proof verification from the verification pipeline.

• Tests

  • Updated snapshot expectations and test cases to reflect the removal of the DID-based identity proof entry.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR removes the openAttestationDidIdentityProof verifier from verification logic and public exports, and updates test snapshots to no longer include the DID-based skipped identity proof entries.

Changes

Cohort / File(s)	Summary
Test Snapshots src/__tests__/core/verify.test.ts	Removed OpenAttestationDidIdentityProof/DID-based issuer identity proof entries from multiple V2/V3 inline snapshots.
Verification Logic & Exports src/verify/verify.ts, src/verify/fragments/index.ts	Deleted openAttestationDidIdentityProof from issuer identity verifiers, from the aggregated verifier list, and from the module's public exports.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

• rongquan1
• RishabhS7

Poem

🐇 I hopped through proofs with care and cheer,
Found a DID that need not linger near.
Snapshots trimmed, exports light and spry,
A tidy hop beneath the sky. ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix: remove did verification for issuer identity' accurately and concisely summarizes the main change: removing DID-based issuer identity verification from the codebase.
Description check	✅ Passed	The description covers the required template sections with adequate detail: Summary explains the main purpose, Changes lists key modifications, but the Issues section is missing.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch maintenance/remove-did

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@src/verify/verify.ts`:
- Line 60: Remove the lingering export/import of openAttestationDidIdentityProof
from src/verify/fragments/index.ts (delete it from the import list and from the
export statement) and ensure the final verifier list constant
openAttestationVerifiers does not reintroduce it by checking
originalOpenAttestationVerifiers (from `@tradetrust-tt/tt-verify`); if
originalOpenAttestationVerifiers includes openAttestationDidIdentityProof,
filter or omit that entry when creating openAttestationVerifiers (the const
openAttestationVerifiers = [...originalOpenAttestationVerifiers]) so the
verifier is excluded even if present upstream.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[tradetrustimda]

🎉 This PR is included in version 2.5.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀