Skip to content

fix: remove did verification for issuer identity #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rongquan1 merged 2 commits into from
Feb 3, 2026
Merged

fix: remove did verification for issuer identity #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9f9f39
fix: remove did verification for issuer identity
pennhan-dex Feb 2, 2026
b4a23e2
fix: remove export of openAttestationDidIdentityProof
pennhan-dex Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions src/__tests__/core/verify.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,16 +729,6 @@ describe.concurrent('V3 verify', () => {
"status": "VALID",
"type": "ISSUER_IDENTITY",
},
{
"name": "OpenAttestationDidIdentityProof",
"reason": {
"code": 0,
"codeString": "SKIPPED",
"message": "Document is not using DID as top level identifier or has not been wrapped",
},
"status": "SKIPPED",
"type": "ISSUER_IDENTITY",
},
]
`);
});
Expand Down Expand Up @@ -810,16 +800,6 @@ describe.concurrent('V3 verify', () => {
"status": "SKIPPED",
"type": "ISSUER_IDENTITY",
},
{
"name": "OpenAttestationDidIdentityProof",
"reason": {
"code": 0,
"codeString": "SKIPPED",
"message": "Document is not using DID as top level identifier or has not been wrapped",
},
"status": "SKIPPED",
"type": "ISSUER_IDENTITY",
},
]
`);
},
Expand Down Expand Up @@ -896,16 +876,6 @@ describe.concurrent('V2 verify', () => {
"status": "SKIPPED",
"type": "ISSUER_IDENTITY",
},
{
"name": "OpenAttestationDidIdentityProof",
"reason": {
"code": 0,
"codeString": "SKIPPED",
"message": "Document is not using DID as top level identifier or has not been wrapped",
},
"status": "SKIPPED",
"type": "ISSUER_IDENTITY",
},
]
`);
});
Expand Down
2 changes: 0 additions & 2 deletions src/verify/fragments/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import {
openAttestationDidIdentityProof,
openAttestationDidSignedDocumentStatus,
openAttestationDnsDidIdentityProof,
openAttestationDnsTxtIdentityProof,
Expand All @@ -20,7 +19,6 @@ import { w3cEmptyCredentialStatus } from './document-status/w3cEmptyCredentialSt
export {
TRANSFERABLE_RECORDS_TYPE,
credentialStatusTransferableRecordVerifier,
openAttestationDidIdentityProof,
openAttestationDidSignedDocumentStatus,
openAttestationDnsDidIdentityProof,
openAttestationDnsTxtIdentityProof,
Expand Down
8 changes: 1 addition & 7 deletions src/verify/verify.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import {
isValid,
openAttestationDidIdentityProof,
openAttestationDidSignedDocumentStatus,
openAttestationDnsDidIdentityProof,
openAttestationDnsTxtIdentityProof,
Expand Down Expand Up @@ -52,17 +51,13 @@ const verifiers = {
credentialStatusTransferableRecordVerifier,
},
issuerIdentity: {
openAttestationDidIdentityProof,
openAttestationDnsDidIdentityProof,
openAttestationDnsTxtIdentityProof,
w3cIssuerIdentity,
},
};

const openAttestationVerifiers = [
...originalOpenAttestationVerifiers,
openAttestationDidIdentityProof,
];
const openAttestationVerifiers = [...originalOpenAttestationVerifiers];
Comment thread
coderabbitai[bot] marked this conversation as resolved.

const w3cVerifiers: Verifier<VerificationFragment>[] = [
w3cSignatureIntegrity,
Expand All @@ -84,7 +79,6 @@ export {
getIdentifier,
createResolver,
utils,
openAttestationDidIdentityProof,
};

export type {
Expand Down