Prefer working-directory files in iOS RFile - #89
Closed
tryk016 wants to merge 1 commit into
Closed
Conversation
Owner
|
Hm, this is probably undesirable. On PC application can load resources by short paths such as "assets/icon.png". With this PR loading of local data will mostly work like on PC, except if there is a file with the same name in working directory. |
Contributor
Author
|
You're right, this could let files from the working directory override bundled resources. I'll fix the OpenGothic call sites to use full paths instead. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relative paths opened through
RFileon iOS are currently resolved only against the application bundle.This change checks the process working directory first and uses the application bundle as a fallback. Absolute-path behavior remains unchanged, and the change is limited to iOS.
Testing: