Skip to content

Renamed CI gate job to the standard "Required checks pass" check#28

Closed
aileen wants to merge 1 commit into
mainfrom
ci/required-checks-pass-gate
Closed

Renamed CI gate job to the standard "Required checks pass" check#28
aileen wants to merge 1 commit into
mainfrom
ci/required-checks-pass-gate

Conversation

@aileen

@aileen aileen commented Jul 6, 2026

Copy link
Copy Markdown
Member

Why

Branch protection on this repo currently requires a status check named exactly All tests pass. Requiring an individual/legacy check name couples branch protection to the CI matrix and to per-repo naming: rename the job and the required check silently no longer exists, blocking every PR.

The org is standardizing every repository on one stable aggregator check named Required checks pass (job id required-checks-pass) that needs every job that must pass. Branch protection then has a single stable target across all repos.

What

  • Renamed the all-tests-pass gate job to required-checks-pass / name: Required checks pass.
  • Coverage is unchanged: the gate still needs: [test], the only other job in the workflow.
  • Top-level permissions: contents: read was already present; no other CI changes.

Merge coordination

The branch ruleset is being updated in the same pass to require Required checks pass instead of All tests pass, so this PR must go green on the new gate before merge.

Branch protection currently requires the check named "All tests pass",
which couples the ruleset to this repo's particular CI naming. The org is
standardizing every repository on a single stable aggregator check named
"Required checks pass" so rulesets can be managed uniformly and CI jobs
can be added or renamed without silently breaking the required check.

The branch ruleset is being updated in the same pass to require the new
check name, so this PR must go green on the new gate before merge. The
gate's coverage is unchanged: it still needs the only other job (test).
@cursor

cursor Bot commented Jul 6, 2026

Copy link
Copy Markdown

Bugbot is not enabled for this team, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 34 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4c9118d2-e2b2-44e3-99cf-687509fc42ca

📥 Commits

Reviewing files that changed from the base of the PR and between a458919 and 4fe4b8d.

📒 Files selected for processing (1)
  • .github/workflows/test.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/required-checks-pass-gate

Comment @coderabbitai help to get the list of available commands.

@aileen

aileen commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

Closing: this repo is a git-subtree force-push mirror of TryGhost/Themes, so editing .github/workflows/test.yml here doesn't stick — the next subtree publish force-overwrites it from packages/<theme>/ in the monorepo.

The CI-gate rename (All tests passRequired checks pass) is being done at the source in TryGhost/Themes#559, which updates both this repo's mirrored test.yml and the monorepo's own gate. This repo's branch-protection ruleset already requires Required checks pass, and the deploy-key ruleset bypass used by the subtree publish has been restored. No action needed here.

@aileen aileen closed this Jul 6, 2026
@aileen aileen deleted the ci/required-checks-pass-gate branch July 6, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant