Cant generate ID if heading is other language in markdown

[goodideal]

Issue Summary

Cant generate ID if heading is other language in markdown

To Reproduce

1. new post, add markdown;
2. add heading with other language, e.g. Chinese;
3. save post, heading has no ID.

Technical details:

• Ghost Version: 3.5.0
• Node Version: docker, ghost:3-alpine
• Browser/OS: ubuntu 16.04
• Database: mysql 3.7

[JaxsonWang]

Yes, hope to solve this problem !

[unsafe-ptr]

Agree,met with the same problem!

In Russian, a post with the name "Название" will be assigned the "/nazvaniie/" address (which is fine). It would be nice if the IDs were generated in the similar way as the post URL.

At the moment, IDs are empty or contain only English words, if they are present in the title.

[goodideal]

A temporary way is to generate heading ids when opening the post with javascript, for example:

var contentSel = '.post-content-main' // depends on ghost theme

if(headings.length){
  // todo: to avoid ghost bug: can't generate heading id if heading is other than English
  for (var idx = 0 ; idx< headings.length; idx++){
    var newId = headings[idx].innerHTML + '-' + Math.random().toString(36).replace(/[^a-z]+/g, '').substr(0, 5)
    headings[idx].setAttribute('id', newId)
  }
}

[sapphi-red]

Ghost/core/server/lib/mobiledoc/converters/markdown-converter.js

Line 13 in c0512e3

var slug = inputString.replace(/[^\w]/g, '').toLowerCase();

Changing this line to var slug = inputString.toLowerCase(); or something will fix this but it will break links which uses characters outside \w.

The slug generation when not using markdown cards differs from it.
These are neither non-latin-characters-friendly. (For example Название becomes -)

Ghost/core/server/lib/mobiledoc/converters/mobiledoc-converter.js

Lines 52 to 58 in c0512e3

	let text = nodeTextContent(node);
	let id = text
	.replace(/[<>&"?]/g, '')
	.trim()
	.replace(/[^\w]/g, '-')
	.replace(/-{2,}/g, '-')
	.toLowerCase();

In my opinion, the slug generation in this vscode's PR is good.

[kevinansfield]

Markdown cards are the primary backwards compatibility mechanism for content from Ghost 0.x, we need to ensure the existing header id generation doesn't change so we don't break anchor links in legacy content. Similarly for the rich-text editor, changing the header id generation should not cause any changes for existing content.

What we can probably do is adapt the current id generation routines so that once an id is generated using the existing algorithm, if it's empty or only contains dashes then we can trigger a more non-latin-char friendly generator. Use of the @tryghost/string's slugify function may be useful there but I'd be interested to know of any approaches that perform better for non-latin languages.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[my9074]

+1

[nag]

Any updates on this?