Skip to content

Self hosted is not truly self hosted #22621

@thany

Description

@thany

Issue Summary

There is a dependency on this url for the search function:

https://cdn.jsdelivr.net/ghost/sodo-search@~1.5/umd/sodo-search.min.js

This one should be self-hosted, and be made part of the javascript build process. Since Ghost is built on top of Node.js, I know this is possible.

Further, I noticed this in the source:

<figure class="gh-card-image">
                <img
                    srcset="https://static.ghost.org/v4.0.0/images/feature-image.jpg 160w,
                            https://static.ghost.org/v4.0.0/images/feature-image.jpg 320w,
                            https://static.ghost.org/v4.0.0/images/feature-image.jpg 600w,
                            https://static.ghost.org/v4.0.0/images/feature-image.jpg 960w,
                            [https://static.ghost.org/v4.0.0/images/feature-image.jpg](view-source:https://static.ghost.org/v4.0.0/images/feature-image.jpg) 1200w,
                            https://static.ghost.org/v4.0.0/images/feature-image.jpg 2000w"
                    sizes="320px"
                    src="https://static.ghost.org/v4.0.0/images/feature-image.jpg"
                    alt="Coming soon"
                    loading="lazy"
                >
            </figure>

That's not supposed to be there. Again, if it's a self-hosted environment, it should be self hosted, not externally hosted. On top of that, it seems like... what, some sort of promotion for Ghost 4.0? It doesn't even matter. Don't bother end-users with something like that. They couldn't be arsed what platform a website runs on, let alone what the next version is all about.

Steps to Reproduce

View source

Ghost Version

5.114.1

Node.js Version

18.20.7

How did you install Ghost?

Docker on Unraid

Database type

Other

Browser & OS version

Firefox on WIndows 10

Relevant log / error output

Code of Conduct

  • I agree to be friendly and polite to people in this repository

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions