🐛 Fixed blog setup crashing for falsy email config#11041
Merged
Conversation
rshbhgrg
force-pushed
the
fix-welcome-email-config
branch
from
65de11c to
149d74e
Compare
rshbhgrg
requested review from
kevinansfield and
naz
and removed request for
naz
refs TryGhost#11040 In case of falsy `sendWelcomeEmail` config, the blog setup crashed as the setup method implicitly returned undefined instead of promise. This handles the fasly config correctly. - Adds regression test for pro config blog setup
rshbhgrg
force-pushed
the
fix-welcome-email-config
branch
from
149d74e to
0c90076
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #11040
In case of falsy
sendWelcomeEmailconfig, the blog setup crashed as the setup method implicitly returned undefined instead of promise. This handles the falsy config correctly by returning a resolved promise and allowing setup to progress.Adds new regression test for blog setup with custom config