🐛 Fixed newsletter and preview to support inlining pseudo css classes#12134
Merged
Conversation
closes TryGhost#12078 - Root cause was that pseudo class .kg-bookmark-author:after was not getting inlined to email newsletter or its preview. - That is where the margin and bullet-point content are added between author and publisher. - Dependency juice supports an option inlinePseudoElements which is false by default. - Fix was to set inlinePseudoElements to true when serializing post email.
Member
|
Hey @jeremydavidson 👋 Thanks for looking into this. Unfortunately pseudo elements are not supported by the majority of email clients which is why it's disabled by default in juice, support is essentially only available in Apple Mail. Do you have any ideas for alternative fixes? |
Contributor
Author
|
Hi @kevinansfield, what I learned juice can do in this solution is to transform pseudo classes into inline html, like it inlines css classes into style attributes. So, in this case, it transforms .kg-bookmark-author:after into a real html element that can render correctly in email clients: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Fixed newsletter and preview to support inlining pseudo css classes
closes #12078
Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!
yarn testandyarn lint)More info can be found by clicking the "guidelines for contributing" link above.