Added reset for stripe related tables on Stripe disconnect#13013
Merged
Conversation
rshbhgrg
force-pushed
the
reset-stripe-disconnect
branch
from
24992ec to
891d39d
Compare
closes https://github.com/TryGhost/Team/issues/724 closes https://github.com/TryGhost/Team/issues/739 Currently, we allow site owners to disconnect Stripe if they don't have any active subscriptions for a member. On disconnect, we want to remove all stripe related data for the old account in DB in these tables - `members_stripe_customers`, `members_stripe_customers_subscriptions`, `stripe_products`, `stripe_prices` , which is otherwise causing issues as the Stripe IDs referred to in these tables can be pointing to a different stripe account than one connected. This was also causing site owners to not be able to create new prices after connecting to new account as we ended up using old stripe product belonging to different account which failed.
rshbhgrg
force-pushed
the
reset-stripe-disconnect
branch
from
891d39d to
62ba177
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes TryGhost/Team#724
Currently, we allow site owners to Disconnect Stripe if they don't have any active subscriptions for a member. On disconnect, we want to remove all stripe related data for the old account in DB in these tables - members_stripe_customers, members_stripe_customers_subscriptions, stripe_products, stripe_prices , which can otherwise cause issues as the Stripe IDs referred to in these tables might be pointing to a different stripe account than one connected.