🐛 Fixed OpenSEa NFT OEmbeds#15372
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #15372 +/- ##
==========================================
+ Coverage 52.87% 52.92% +0.04%
==========================================
Files 1393 1393
Lines 89609 89605 -4
Branches 10164 10166 +2
==========================================
+ Hits 47382 47421 +39
+ Misses 42174 42131 -43
Partials 53 53
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
SimonBackx
approved these changes
Sep 6, 2022
refs TryGhost/Product#1879 OpenSea updated their URL format for NFTs after adding support for Solana which broke our regex, this updates to support the new format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs https://github.com/TryGhost/Team/issues/1879
OpenSea updated their URL format for NFTs after adding support for Solana
which broke our regex, this updates to support the new format.