Removed Bluebird dependency#17831
Merged
daniellockyer merged 5 commits intoAug 29, 2023
Merged
Conversation
refs TryGhost#14882 with this the Bluebird is no longer required in ghost/core
ghost/coreghost/core
Contributor
Author
|
Hi @daniellockyer, thanks for running the CI tests! I didn't realize there's a distinct test suite for the core, and how it doesn't automatically execute when running yarn test from the monorepo root. Will fix it today or tomorrow. |
refs TryGhost#14882 with this the Bluebird is no longer required in ghost/core
Contributor
Author
|
Instead of transforming raw_knex into an asynchronous function, I chose to make one minor change to eliminate the need for Bluebird's Promise.props. This approach successfully achives the goal of eliminating Bluebird from the core. Furthermore, I verified that executing |
chairulakmal
commented
Aug 29, 2023
…previously returned by Promise.props refs TryGhost#14882
ghost/core
Contributor
|
Thanks @chairulakmal! 😀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #14882
👋 Hi there! I'm a new contributor and I've made minimum changes to the last file requiring Bluebird and then remove it from
ghost/core. I tried to refactor the code to operate with async/await but after realizing how raw-knex is used, I opted to instead do a one line change where Bluebird Promise.props is used. Subsequently I updated the core package.json by removing Bluebird, since it's now unnecessary for any file in ghost/core. Your feedback is much appreciated!Thanks,
kai
Please include a description of your change & check your PR against this list, thanks!
yarn test:allin core andyarn lint)We appreciate your contribution!
🤖 Generated by Copilot at e625a9f
This pull request removes the
bluebirdlibrary and updates theraw_knexplugin to use native promises methods. This simplifies the code and reduces the number of dependencies in the project.