Cleaned up queries in admin-x-activitypub

[mike182uk]

no refs

Clean up includes:

• Removing unused queries (inbox, following, followers)
• Renaming of query hooks to be consistent with other hooks
• Fixed useProfile*ForUser fns as these where using the incorrect handle to setup the API client
• Refactored query keys to make mutations easier to reason about
• Fixed follow / unfollow mutations not working as expected

[coderabbitai]

Walkthrough

The pull request refactors the ActivityPub API by renaming several profile-related methods and removing others. Methods formerly named getFollowersForProfile, getFollowingForProfile, and getPostsForProfile are now getProfileFollowers, getProfileFollowing, and getProfilePosts, respectively, with corresponding changes in their response interfaces. Additionally, the getInbox, getFollowing, and getFollowers methods have been removed from both the API implementation and its tests. Updates also affect hooks used in components such as Inbox, Search, FollowButton, and the profile modals, which now use user-specific hooks (e.g., useSuggestedProfilesForUser, useFollowMutationForUser, useProfilePostsForUser). The useActivityPubQueries file has been reorganized with a centralized QUERY_KEYS object, and several redundant functions have been removed.

Possibly related PRs

• Updated profile tab to use dedicated account endpoints in admin-x-activitypub #22010: Involves renaming and removal of methods in the ActivityPubAPI, mirroring the API structure changes in this PR.
• Updated FollowButton with "unfollow" design #22057: Introduces modifications to the unfollow functionality in ActivityPubAPI, closely aligning with the current changes.
• Wired Repost button to the new ActivityPub endpoint #22111: Focuses on method renaming and new method introductions in ActivityPubAPI, directly related to the refactoring in this PR.

Suggested labels

browser-tests

Poem

I'm a rabbit in the code garden, hopping free,
Renamed methods bloom like carrots for all to see,
Old tests and hooks dig their final goodbye,
New user-centric paths make my ears stand high,
With every refactor, I nibble joyously in glee!

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/admin-x-activitypub/src/components/Inbox.tsx

Oops! Something went wrong! :(

ESLint: 8.44.0

ESLint couldn't find the plugin "eslint-plugin-react-hooks".

(The package "eslint-plugin-react-hooks" was not found when loaded as a Node module from the directory "/apps/admin-x-activitypub".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-react-hooks@latest --save-dev

The plugin "eslint-plugin-react-hooks" was referenced from the config file in "apps/admin-x-activitypub/.eslintrc.cjs".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

apps/admin-x-activitypub/src/components/global/FollowButton.tsx

Oops! Something went wrong! :(

ESLint: 8.44.0

ESLint couldn't find the plugin "eslint-plugin-react-hooks".

(The package "eslint-plugin-react-hooks" was not found when loaded as a Node module from the directory "/apps/admin-x-activitypub".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-react-hooks@latest --save-dev

The plugin "eslint-plugin-react-hooks" was referenced from the config file in "apps/admin-x-activitypub/.eslintrc.cjs".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

apps/admin-x-activitypub/src/api/activitypub.test.ts

Oops! Something went wrong! :(

ESLint: 8.44.0

ESLint couldn't find the plugin "eslint-plugin-react-hooks".

(The package "eslint-plugin-react-hooks" was not found when loaded as a Node module from the directory "/apps/admin-x-activitypub".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-react-hooks@latest --save-dev

The plugin "eslint-plugin-react-hooks" was referenced from the config file in "apps/admin-x-activitypub/.eslintrc.cjs".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

• 4 others

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bc37f87 and 275ccce.

📒 Files selected for processing (7)

• apps/admin-x-activitypub/src/api/activitypub.test.ts (20 hunks)
• apps/admin-x-activitypub/src/api/activitypub.ts (4 hunks)
• apps/admin-x-activitypub/src/components/Inbox.tsx (2 hunks)
• apps/admin-x-activitypub/src/components/Search.tsx (2 hunks)
• apps/admin-x-activitypub/src/components/global/FollowButton.tsx (2 hunks)
• apps/admin-x-activitypub/src/components/modals/ViewProfileModal.tsx (6 hunks)
• apps/admin-x-activitypub/src/hooks/useActivityPubQueries.ts (26 hunks)

🔇 Additional comments (7)

apps/admin-x-activitypub/src/components/Search.tsx (2)

15-15: LGTM! Import statement updated for consistency.

The import statement has been updated to use the renamed hooks, which aligns with the PR's objective of ensuring consistent hook naming across the codebase.

---

175-175: LGTM! Hook usage updated to match the new naming.

The hook usage has been correctly updated to use useSuggestedProfilesForUser while maintaining the same parameters, ensuring consistent behavior.

apps/admin-x-activitypub/src/components/Inbox.tsx (2)

18-18: LGTM! Import change aligns with standardization effort.

The updated import maintains consistency with other user-specific hooks in the codebase.

---

59-59: LGTM! Hook usage follows the new naming convention.

The change to useSuggestedProfilesForUser aligns with other user-specific hooks like useActivitiesForUser and useUserDataForUser, improving consistency across the codebase.

apps/admin-x-activitypub/src/api/activitypub.ts (1)

47-66: LGTM! Well-structured API changes.

The renaming of interfaces and methods improves clarity by consistently prefixing profile-related operations with "profile". The implementations remain functionally equivalent and maintain proper error handling.

Also applies to: 298-389

apps/admin-x-activitypub/src/api/activitypub.test.ts (2)

507-739: LGTM! Well-structured test suite for getProfileFollowers.

The test suite is comprehensive, covering token passing, response handling, pagination, and error cases.

---

741-973: LGTM! Well-structured test suite for getProfileFollowing.

The test suite is comprehensive, covering token passing, response handling, pagination, and error cases.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.