Skip to content

Added frontend and email support for link colors in CTA cards#22495

Merged
kevinansfield merged 1 commit intomainfrom
cta-link-color
Mar 18, 2025
Merged

Added frontend and email support for link colors in CTA cards#22495
kevinansfield merged 1 commit intomainfrom
cta-link-color

Conversation

@sanne-san
Copy link
Contributor

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 13, 2025

Walkthrough

This pull request adds two new CSS rules in both the core frontend and email template styles. In the core frontend file, anchor elements within the .kg-cta-sponsor-label and .kg-cta-text classes nested in the .kg-cta-link-accent container are set to use the var(--ghost-accent-color) variable. In the email template partial, similar rules are introduced to assign the dynamic {{accentColor}} value to the same anchor elements, enforced with the !important flag. These changes update the styling for call-to-action link components across different modules without removing any existing styles.

Possibly related PRs

Suggested labels

deploy-to-staging

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cae330b and c80e869.

⛔ Files ignored due to path filters (3)
  • ghost/core/test/e2e-api/admin/__snapshots__/email-previews.test.js.snap is excluded by !**/*.snap
  • ghost/core/test/integration/services/email-service/__snapshots__/batch-sending.test.js.snap is excluded by !**/*.snap
  • ghost/core/test/integration/services/email-service/__snapshots__/cards.test.js.snap is excluded by !**/*.snap
📒 Files selected for processing (2)
  • ghost/core/core/frontend/src/cards/css/cta.css (2 hunks)
  • ghost/email-service/lib/email-templates/partials/styles.hbs (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (12)
  • GitHub Check: Unit tests (Node 22.13.1)
  • GitHub Check: Unit tests (Node 20.11.1)
  • GitHub Check: Unit tests (Node 18.12.1)
  • GitHub Check: Regression tests (Node 20.11.1, sqlite3)
  • GitHub Check: Regression tests (Node 20.11.1, mysql8)
  • GitHub Check: Database tests (Node 20.11.1, sqlite3)
  • GitHub Check: Database tests (Node 22.13.1, mysql8)
  • GitHub Check: Database tests (Node 20.11.1, mysql8)
  • GitHub Check: Ghost-CLI tests
  • GitHub Check: Database tests (Node 18.12.1, mysql8)
  • GitHub Check: Lint
  • GitHub Check: i18n
🔇 Additional comments (4)
ghost/core/core/frontend/src/cards/css/cta.css (2)

83-85: Added styling for accent-colored links in sponsor labels.

This CSS rule correctly applies the accent color (--ghost-accent-color) to links within the sponsor label when the CTA card has the kg-cta-link-accent class, extending the link color customization capabilities.


182-184: Added styling for accent-colored links in CTA text.

This rule appropriately applies the accent color to links within the CTA text content when the card has the kg-cta-link-accent class, ensuring consistent accent color application across the component.

ghost/email-service/lib/email-templates/partials/styles.hbs (2)

1057-1059: Email template implementation for sponsor label links.

The rule uses {{accentColor}} with !important to ensure the accent color is properly applied to sponsor label links in email templates, mirroring the frontend implementation.


1108-1110: Email template implementation for CTA text links.

This rule correctly implements the accent color for CTA text links in email templates with the same approach as the sponsor label, ensuring consistent styling across both frontend and email experiences.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kevinansfield kevinansfield merged commit ebb1b33 into main Mar 18, 2025
26 checks passed
@kevinansfield kevinansfield deleted the cta-link-color branch March 18, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants