Removed unused soft feature flags from ActivityPub

[minimaluminium]

No description provided.

[coderabbitai]

Walkthrough

This change alters the FEATURE_FLAGS constant in the feature-flags.tsx file, switching its value from an array containing the strings 'onboarding' and 'feedback' to an empty array. As a result, the derived type FeatureFlag will now only accommodate string values without any predefined flags, affecting the behavior of functions such as getDefaultState and parseUrlParams that use this constant. The update essentially disables any feature flag management within the module, as the previously available flags are removed.

Possibly related PRs

• Added ActivityPub soft feature flags #22361: Modifies the feature flag system in feature-flags.tsx and impacts related functions, aligning closely with these changes.
• Feedback box for ActivityPub #22496: Introduces a new component that relies on the useFeatureFlags hook, thereby linking to adjustments in feature flag definitions.
• Added onboarding to ActivityPub #22427: Involves modifications to the onboarding feature flag within feature-flags.tsx, directly related to the current change.

Suggested reviewers

• peterzimon

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/admin-x-activitypub/src/lib/feature-flags.tsx

Oops! Something went wrong! :(

ESLint: 8.44.0

ESLint couldn't find the plugin "eslint-plugin-react-hooks".

(The package "eslint-plugin-react-hooks" was not found when loaded as a Node module from the directory "/apps/admin-x-activitypub".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-react-hooks@latest --save-dev

The plugin "eslint-plugin-react-hooks" was referenced from the config file in "apps/admin-x-activitypub/.eslintrc.cjs".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 239142e and 60b1146.

📒 Files selected for processing (1)

• apps/admin-x-activitypub/src/lib/feature-flags.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: Unit tests (Node 22.13.1)
• GitHub Check: Unit tests (Node 20.11.1)
• GitHub Check: Unit tests (Node 18.12.1)
• GitHub Check: Lint

🔇 Additional comments (1)

apps/admin-x-activitypub/src/lib/feature-flags.tsx (1)

5-5:

Details

❓ Verification inconclusive

Removed all predefined feature flags.

The change removes 'onboarding' and 'feedback' feature flags, leaving FEATURE_FLAGS as an empty array. This effectively means:

1. There are no longer any predefined feature flags in the system
2. The getDefaultState() function will now initialize with an empty object
3. The parseUrlParams() function will no longer process any specific flags from URL parameters
4. FeatureFlag type now effectively becomes just string

The PR title indicates this is an intentional removal of unused soft feature flags, which aligns with this change.

---

🏁 Script executed:

#!/bin/bash
# Check if these feature flags are referenced elsewhere in the codebase
echo "Checking for references to the removed feature flags..."
rg -l "'onboarding'" --type tsx --type jsx apps/admin-x-activitypub
rg -l "'feedback'" --type tsx --type jsx apps/admin-x-activitypub

Length of output: 326

---

Action Required: Verify Feature Flag Removal

The change in apps/admin-x-activitypub/src/lib/feature-flags.tsx intentionally removes the predefined feature flags ('onboarding' and 'feedback'), which should mean that no references to these flags remain in the codebase. However, our initial search using file type filters resulted in errors (specifically, "unrecognized file type: tsx"). To ensure complete verification, please run the updated search commands below that do not limit the file types:

#!/bin/bash
# Updated search commands for removed feature flags without file-type filters
echo "Searching for 'onboarding' references in apps/admin-x-activitypub..."
rg -l "'onboarding'" apps/admin-x-activitypub

echo "Searching for 'feedback' references in apps/admin-x-activitypub..."
rg -l "'feedback'" apps/admin-x-activitypub

Please verify that these commands produce no output—confirming that the removed feature flags are indeed not referenced elsewhere.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.