Minor Traffic Analytics UI fixes

[peterzimon]

• Fixed "NaN" output for bounce rate and visit duration
• Fixed jumping dropdowns

[coderabbitai]

Walkthrough

The pull request updates the formatting logic within the processData method of the KpisOverview class. The modifications now include checking for NaN and falsy values when processing KPI metrics such as avg_session_sec, pageviews, visits, and bounce_rate. If an invalid value is detected, a default value is used (e.g., '0m' for average session duration or '0' for numeric values). Additionally, the HTML template in stats.hbs has been restructured to organize the components better. The button handling mock data and the wrapping of components like AudienceFilter and PowerSelect within <div> elements have been reformatted for improved readability without altering their functionality. No modifications were made to the exported or public entity declarations.

Possibly related PRs

• Improved visit duration formatting in Analytics #22558: Modifies the avg_session_sec calculation using the formatVisitDuration function, indicating a strong code-level link.
• Fixed bounce rate % in the KPIs chart tooltip #22548: Focuses on the formatting of the bounce rate within KPI components, directly relating to the bounce rate adjustments in this PR.

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ghost/admin/app/components/stats/kpis-overview.js

Oops! Something went wrong! :(

ESLint: 8.44.0

Error: Failed to load parser '@babel/eslint-parser' declared in 'ghost/admin/.eslintrc.js': Cannot find module '@babel/eslint-parser'
Require stack:

• /ghost/admin/.eslintrc.js
  at Module._resolveFilename (node:internal/modules/cjs/loader:1248:15)
  at Function.resolve (node:internal/modules/helpers:145:19)
  at Object.resolve (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2346:46)
  at ConfigArrayFactory._loadParser (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3325:39)
  at ConfigArrayFactory._normalizeObjectConfigDataBody (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3099:43)
  at _normalizeObjectConfigDataBody.next ()
  at ConfigArrayFactory._normalizeObjectConfigData (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3040:20)
  at _normalizeObjectConfigData.next ()
  at ConfigArrayFactory.loadInDirectory (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2886:28)
  at CascadingConfigArrayFactory._loadConfigInAncestors (/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3871:46)

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cbae47f and 716de1d.

📒 Files selected for processing (2)

• ghost/admin/app/components/stats/kpis-overview.js (1 hunks)
• ghost/admin/app/templates/stats.hbs (1 hunks)

🧰 Additional context used

🧬 Code Definitions (1)

ghost/admin/app/components/stats/kpis-overview.js (1)

ghost/admin/app/utils/stats.js (1) (1)

• formatVisitDuration (133-154)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Admin tests - Chrome

🔇 Additional comments (6)

ghost/admin/app/templates/stats.hbs (3)

5-12: Button formatting looks good.

The code formatting adjustments improve readability while preserving functionality.

---

14-19: Appropriate container for AudienceFilter.

Wrapping the AudienceFilter component in a div container helps prevent UI jumping during rendering and interaction, which aligns with the PR objective of fixing jumping dropdowns.

---

21-36: Good dropdown container implementation.

Adding a container div around the PowerSelect component helps stabilize its position in the UI, preventing it from jumping during interactions. This addresses one of the main objectives of the PR.

ghost/admin/app/components/stats/kpis-overview.js (3)

99-101: Good variable extraction for formatted values.

Extracting these calculations into named variables improves code readability and makes the return statement cleaner.

---

104-105: Good default handling for numeric metrics.

Using the || '0' pattern ensures that falsy values (including undefined, null, or empty string) are replaced with a default of '0', preventing empty or NaN displays.

---

106-106: Proper bounce rate formatting.

The conditional logic correctly handles NaN and falsy values for bounce rate, which addresses one of the main objectives of the PR to fix NaN outputs.

[coderabbitai]

⚠️ Potential issue

Fix conditional logic for avg_session_sec.

There's a logical error in this condition. The current implementation will always return '0m' when formattedVisitDurations is truthy, which is the opposite of what's intended.

-avg_session_sec: isNaN(formattedVisitDurations) || formattedVisitDurations ? '0m' : formattedVisitDurations,
+avg_session_sec: isNaN(formattedVisitDurations) || !formattedVisitDurations ? '0m' : formattedVisitDurations,

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	avg_session_sec: isNaN(formattedVisitDurations) || formattedVisitDurations ? '0m' : formattedVisitDurations,
	avg_session_sec: isNaN(formattedVisitDurations) || !formattedVisitDurations ? '0m' : formattedVisitDurations,