Merged
Conversation
- no functionality change, just making it easier to read
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request removes various configurations and dependencies related to the identity token service. In the Dockerfile, the instruction to copy the service’s package.json is deleted, and the associated volume for its node modules is removed from the Docker Compose configuration. The dependency on the identity token service package is eliminated from the main package.json, and import paths across core server files and tests have been updated to reference local definitions instead of the external package. Additionally, minor formatting adjustments have been made in documentation and JSDoc comments, and several ESLint and TypeScript configuration files as well as service documentation have been removed. Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (15)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
fix https://linear.app/ghost/issue/ENG-2110/identity-token-service - this commit moves the lib code and tests to the core folder so we can colocate code in one place rather than splitting it out across packages, which increases the cognitive load and overhead
daniellockyer
force-pushed
the
daniel-refactor
branch
2 times, most recently
from
60bd521 to
4367f52
Compare
- I should not live forever in the codebase :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚧