Fixed kpis chart not displaying graph

[9larsons]

no ref

The return value was a.date instead of date, which the chart didn't pick up.

[coderabbitai]

Walkthrough

The pull request modifies how the date field is referenced in both SQL queries and test result files. In the api_kpis.pipe file, the SQL query has been updated by changing the date column selection from a.date to a.date as date, clarifying the alias used for the date. Additionally, two test result files have been updated to reflect this change by altering the header line in the CSV-like data formats: the header "a.date" has been replaced with "date". No other changes were made to the logic, data structure, or public entity declarations within these files.

Possibly related PRs

• Fixed last 24 hour view for KPI chart #22551: Addresses adjustments to date formatting in the KPI chart tooltip, involving similar handling of the date field from the SQL query.
• Fixed kpi pageview stats when filtering by pathname #22674: Implements broader modifications to how date handling is managed in the same file, directly relating to the changes in the SQL query's aliasing of the date column.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 924ef22 and 4f02127.

📒 Files selected for processing (3)

• ghost/web-analytics/pipes/api_kpis.pipe (1 hunks)
• ghost/web-analytics/tests/date_range_one_day_filter_pathname_about_kpis.test.result (1 hunks)
• ghost/web-analytics/tests/filter_pathname_about_kpis.test.result (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: Tinybird Tests (Web Analytics)
• GitHub Check: Unit tests (Node 22.13.1)
• GitHub Check: Unit tests (Node 20.11.1)
• GitHub Check: Unit tests (Node 18.12.1)

🔇 Additional comments (3)

ghost/web-analytics/pipes/api_kpis.pipe (1)

186-193: Correct Alias for Date Field:
The SQL query now explicitly aliases the result column using a.date as date. This change fixes the issue where the KPIs chart was not rendering the graph—downstream consumers will correctly receive the date value under the unified name date. Please ensure that any join or filtering logic that references this column is updated accordingly.

ghost/web-analytics/tests/filter_pathname_about_kpis.test.result (1)

1-1: Header Standardization:
The header has been updated from "a.date" to "date", which now aligns with the alias provided by the SQL query in the api_kpis.pipe file. This change promotes consistency in the column naming across the system.

ghost/web-analytics/tests/date_range_one_day_filter_pathname_about_kpis.test.result (1)

1-1: Consistent CSV Header:
The CSV header has been adjusted to use "date" instead of "a.date", ensuring it matches the alias in the SQL query. This consistency will help prevent data misinterpretation in tests and any downstream processing.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.