Conversation
no ref Need to bump version to try to resolve CI deploy issues.
WalkthroughThe pull request updates version identifiers across multiple files from version 7 to version 8. In the Ghost admin area and various web analytics components—such as datasources, pipes, and scripts—the constant and variable values representing the version have been incremented. In particular, the change in the Possibly related PRs
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it’s a critical failure. 🔧 ESLint
ghost/admin/app/utils/stats.jsOops! Something went wrong! :( ESLint: 8.44.0 Error: Failed to load parser '@babel/eslint-parser' declared in 'ghost/admin/.eslintrc.js': Cannot find module '@babel/eslint-parser'
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
ghost/web-analytics/datasources/_mv_session_data.datasource (1)
1-1: Version updated from 7 to 8 as part of coordinated version bumpThe datasource version has been updated from 7 to 8, matching the version changes across all other web analytics components in this PR.
Note: The comment on line 2 references "Pipe 'mv_session_data__v7'" which hasn't been updated. This doesn't affect functionality but might be worth updating for consistency.
ghost/web-analytics/pipes/api_top_sources.pipe (1)
4-4: Consider updating the token name to match the versionThe token name still contains "v7" while the version has been updated to 8.
-TOKEN "api_top_sources__v7_endpoint_read_2345" READ +TOKEN "api_top_sources__v8_endpoint_read_2345" READ
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
ghost/admin/app/utils/stats.js(1 hunks)ghost/web-analytics/datasources/_mv_hits.datasource(1 hunks)ghost/web-analytics/datasources/_mv_session_data.datasource(1 hunks)ghost/web-analytics/pipes/api_kpis.pipe(3 hunks)ghost/web-analytics/pipes/api_top_browsers.pipe(1 hunks)ghost/web-analytics/pipes/api_top_devices.pipe(1 hunks)ghost/web-analytics/pipes/api_top_locations.pipe(1 hunks)ghost/web-analytics/pipes/api_top_os.pipe(1 hunks)ghost/web-analytics/pipes/api_top_pages.pipe(1 hunks)ghost/web-analytics/pipes/api_top_sources.pipe(1 hunks)ghost/web-analytics/pipes/mv_hits.pipe(1 hunks)ghost/web-analytics/pipes/mv_session_data.pipe(1 hunks)ghost/web-analytics/scripts/exec_test.sh(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Tinybird Tests (Web Analytics)
- GitHub Check: Admin tests - Chrome
🔇 Additional comments (14)
ghost/admin/app/utils/stats.js (1)
3-3: Version updated from 7 to 8 as part of coordinated version bumpThe TB_VERSION constant has been updated from 7 to 8, which aligns with similar updates across all web analytics components in this PR.
ghost/web-analytics/pipes/api_top_os.pipe (1)
1-1: Version updated from 7 to 8 as part of coordinated version bumpThe version number has been incremented as part of the version update across all web analytics components. No functional changes to the query logic or parameters have been made.
ghost/web-analytics/datasources/_mv_hits.datasource (1)
1-1: Version updated from 7 to 8 as part of coordinated version bumpThe version number has been incremented while maintaining the same schema definition and storage engine configuration.
ghost/web-analytics/pipes/mv_session_data.pipe (1)
1-1: Version Update to VERSION 8.The version declaration has been successfully updated from "VERSION 7" to "VERSION 8". This change is straightforward and aligns with the coordinated version bump across similar files. Please verify that any external components or deployment scripts referencing the old version are updated as well.
ghost/web-analytics/pipes/mv_hits.pipe (1)
1-1: Version Update to VERSION 8 for mv_hits.The version change from "VERSION 7" to "VERSION 8" is correctly applied at the top of the file. This update maintains the integrity of the SQL query and node definitions without affecting functionality.
ghost/web-analytics/pipes/api_top_devices.pipe (1)
1-1: Version Update to VERSION 8 in API Top Devices.The version bump to "VERSION 8" is clear and non-intrusive, ensuring consistent version tracking. The token ("stats_page") and SQL logic remain unaltered.
ghost/web-analytics/pipes/api_top_locations.pipe (1)
1-1: Version Update to VERSION 8 in API Top Locations.The update from "VERSION 7" to "VERSION 8" is properly applied and does not introduce any changes to the SQL query logic. This change is part of the overall coordinated version bump.
ghost/web-analytics/pipes/api_top_pages.pipe (1)
1-1: Version Update to VERSION 8 in API Top Pages.The version declaration has been updated to "VERSION 8" without affecting the underlying SQL statements or node definitions. This change is consistent with the other analytics pipes in the project.
ghost/web-analytics/pipes/api_top_browsers.pipe (1)
1-1: Version update from 7 to 8 looks goodThe version has been correctly updated as part of the coordinated version bump across multiple files in the project.
ghost/web-analytics/scripts/exec_test.sh (1)
7-7: Environment variable default version properly updatedThe TB_VERSION environment variable default has been updated from 7 to 8, maintaining consistency with the version changes across other files.
ghost/web-analytics/pipes/api_top_sources.pipe (1)
1-1: Version update from 7 to 8 looks goodThe version has been correctly updated as part of the coordinated version bump across multiple files.
ghost/web-analytics/pipes/api_kpis.pipe (3)
1-1: Version update from 7 to 8 looks goodThe version has been correctly updated as part of the coordinated version bump across multiple files.
82-93: New source_sessions node effectively adds an additional filtering layerThe addition of this node enhances filtering capabilities by joining session data with filtered sessions and applying an optional source filter.
127-129: Updated session_metrics join logic leverages the new source_sessions nodeThe join logic has been improved to use the new source_sessions filtering node, which should provide more consistent and optimized filtering.
1 participant
no ref
Need to bump version to try to resolve CI deploy issues.