Skip to content

Moved @tryghost/mw-version-match to core folder#22714

Merged
daniellockyer merged 3 commits intomainfrom
daniel-packages
Mar 31, 2025
Merged

Moved @tryghost/mw-version-match to core folder#22714
daniellockyer merged 3 commits intomainfrom
daniel-packages

Conversation

@daniellockyer
Copy link
Contributor

fix https://linear.app/ghost/issue/ENG-2112/mw-version-match

  • this commit moves the lib code and tests to the core folder so we can
    colocate code in one place rather than splitting it out across
    packages, which increases the cognitive load and overhead

fix https://linear.app/ghost/issue/ENG-2112/mw-version-match

- this commit moves the lib code and tests to the core folder so we can
  colocate code in one place rather than splitting it out across
  packages, which increases the cognitive load and overhead
fix https://linear.app/ghost/issue/ENG-2113/importer-handler-content-files

- this commit moves the lib code and tests to the core folder so we can
  colocate code in one place rather than splitting it out across
  packages, which increases the cognitive load and overhead
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 31, 2025

Walkthrough

This change removes dependencies on the importer-handler-content-files, mw-version-match, and announcement-bar-settings packages from the project. Specifically, it deletes certain COPY commands in the Dockerfile and corresponding volume mounts in the Docker Compose configuration. Additionally, the import paths in both the application source and test files have been updated to use local modules rather than external packages. The adjustments include altering entry points and middleware references, as well as directly exporting functions. Package dependencies for these modules have been removed from the core package manifest. Multiple configuration and documentation files related to these packages, such as ESLint files and README documents, have also been deleted. Overall, the modifications consolidate the modules into the local codebase and eliminate external package dependencies.

Possibly related PRs


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 84cfc7e and cde090c.

📒 Files selected for processing (10)
  • compose.yml (0 hunks)
  • ghost/announcement-bar-settings/.eslintrc.js (0 hunks)
  • ghost/announcement-bar-settings/README.md (0 hunks)
  • ghost/announcement-bar-settings/index.js (0 hunks)
  • ghost/announcement-bar-settings/package.json (0 hunks)
  • ghost/announcement-bar-settings/test/.eslintrc.js (0 hunks)
  • ghost/core/core/server/api/endpoints/utils/validators/input/settings.js (1 hunks)
  • ghost/core/core/server/services/announcement-bar-service/index.js (1 hunks)
  • ghost/core/package.json (0 hunks)
  • ghost/core/test/unit/server/services/announcement-bar/AnnouncementBarSettings.test.js (1 hunks)
💤 Files with no reviewable changes (7)
  • ghost/announcement-bar-settings/test/.eslintrc.js
  • ghost/announcement-bar-settings/package.json
  • ghost/announcement-bar-settings/index.js
  • ghost/core/package.json
  • ghost/announcement-bar-settings/README.md
  • compose.yml
  • ghost/announcement-bar-settings/.eslintrc.js
✅ Files skipped from review due to trivial changes (2)
  • ghost/core/core/server/api/endpoints/utils/validators/input/settings.js
  • ghost/core/test/unit/server/services/announcement-bar/AnnouncementBarSettings.test.js
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: Ghost-CLI tests
  • GitHub Check: Unit tests (Node 22.13.1)
  • GitHub Check: Unit tests (Node 20.11.1)
  • GitHub Check: Database tests (Node 22.13.1, mysql8)
  • GitHub Check: Unit tests (Node 18.12.1)
  • GitHub Check: Database tests (Node 20.11.1, mysql8)
  • GitHub Check: Database tests (Node 18.12.1, mysql8)
🔇 Additional comments (1)
ghost/core/core/server/services/announcement-bar-service/index.js (1)

2-2: Import path updated from package to local module.

The change correctly reflects the PR's objective of consolidating code into the core folder, replacing the external package dependency @tryghost/announcement-bar-settings with a local module reference. This simplifies the codebase structure and reduces external dependencies.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

fix https://linear.app/ghost/issue/ENG-2114/announcement-bar-settings

- this commit moves the lib code and tests to the core folder so we can
  colocate code in one place rather than splitting it out across
  packages, which increases the cognitive load and overhead
@daniellockyer daniellockyer merged commit 900de81 into main Mar 31, 2025
26 checks passed
@daniellockyer daniellockyer deleted the daniel-packages branch March 31, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant