Added Tinybird tests for the pathname filter for all endpoints#22780
Added Tinybird tests for the pathname filter for all endpoints#22780
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request introduces a new SQL query that joins two tables to retrieve web analytics data specific to the Possibly Related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ref https://linear.app/ghost/issue/ANAL-194/automated-tests-for-all-queries-including-every-filter-plus-one-other
This commit adds Tinybird fixture tests for filtering by pathname for
all endpoints that didn't previously have these tests
This is part of an effort to generally improve our test coverage on
our Tinybird endpoints so that we can more confidently make changes to
them without breaking other endpoints or filter combinations
The one excluded endpoint is the top_sources endpoint, because it is giving incorrect results. I'll raise a separate PR with that test added with the correct results so that we can fix the implementation to get it to pass.