-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
🌵pnpm? #23375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| "react-hot-toast": "2.5.2", | ||
| "@dnd-kit/sortable": "7.0.2", | ||
| "react-select": "5.10.1", | ||
| "clsx": "2.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the bare minimum, would be really good to pull out all the missing dependency fixes and merge those!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep that's the plan! We'll need to do it for pnpm or yarn4, so trying to get the ball rolling on the stuff we can do in advance 👌 (in their own PRs of course)
|
One thing to consider if this becomes mainlined is that the CLI currently installs Ghost using a bundled yarn 1.x dependency. If the core package manager switches to Yarn4 or pnpm, the CLI should probably do the same |
|
Closing this as we don't have immediate plans to actually implement this. We can still use it as a reference for updating dependencies and taking baby steps in this direction though. |
just for fun