Added vitest as dependency to all packages that use it #23382
Conversation
WalkthroughThis change updates the development dependencies in several package.json files across multiple apps. Specifically, it adds the "vitest" package at version 0.34.3 to the devDependencies of the admin-x-activitypub, admin-x-design-system, shade, and stats apps. Additionally, it downgrades the "vitest" package from version 3.1.3 to 0.34.3 in the posts app. No other dependencies, scripts, or configurations are altered, and there are no changes to exported or public entities in any of the affected packages. Possibly related PRs
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #23382 +/- ##
=======================================
Coverage 72.70% 72.70%
=======================================
Files 1529 1529
Lines 110842 110842
Branches 13648 13648
=======================================
Hits 80589 80589
+ Misses 29247 29228 -19
- Partials 1006 1025 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/shade/package.json (1)
52-53: Review added test framework dependencies
vitest@0.34.3is correctly added to enable unit testing, aligning with the rest of the repo.However,
mocha@10.8.2is also newly added but is not referenced in anyscripts. If Mocha is not used elsewhere, consider removing it to reduce unused dependencies.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (5)
apps/admin-x-activitypub/package.json(1 hunks)apps/admin-x-design-system/package.json(1 hunks)apps/posts/package.json(1 hunks)apps/shade/package.json(1 hunks)apps/stats/package.json(1 hunks)
🔇 Additional comments (5)
apps/posts/package.json (1)
34-34: Align testing framework version across packagesDowngrading
vitestto0.34.3aligns this package with the versions in other apps. Thetest:unitscript will now run with the correct version. All looks consistent.apps/admin-x-activitypub/package.json (1)
39-40: Ensure Vite and Vitest are declared as devDependenciesAdding
"vite": "4.5.14"and"vitest": "0.34.3"ensures that both the build (vite) and test (vitest) tools are available for local development and CI. The versions align with other packages in the monorepo.apps/stats/package.json (1)
45-46: Add Vite and Vitest for dev workflowsIncluding
"vite": "4.5.14"and"vitest": "0.34.3"indevDependenciesensures consistent tooling for local development and testing. The testing scripts (vitestcommands) anddevscripts (vite) will now resolve correctly.apps/admin-x-design-system/package.json (2)
60-60: Verify thevite-plugin-svgraddition
vite-plugin-svgrhas been added, but I don’t see it referenced in the Vite configuration. Ensure thatvite.config.ts(or equivalent) imports and uses this plugin; otherwise, remove it to avoid an unused dependency.
61-61: Align testing framework versionAdding
vitest@0.34.3aligns tests with other packages. Thetest:unitscript will now run using this version.
1 participant
no refs
Vitest is used in all these packages, but it wasn't declared as a dependency in their
package.jsonfiles.For the posts app, I recently set it up with vitest using a later version (3.4.3). This downgrades it to stay aligned with all the other packages using vitest.