Skip to content

Conversation

@minimaluminium
Copy link
Member

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 12, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ap-zustand-notes-and-like-experiment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.38%. Comparing base (f6b579c) to head (44b671c).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24896      +/-   ##
==========================================
- Coverage   71.43%   71.38%   -0.06%     
==========================================
  Files        1531     1530       -1     
  Lines      116067   116041      -26     
  Branches    13973    13972       -1     
==========================================
- Hits        82918    82834      -84     
- Misses      32158    32200      +42     
- Partials      991     1007      +16     
Flag Coverage Δ
admin-tests 47.93% <ø> (-0.43%) ⬇️
e2e-tests 71.38% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ErisDS ErisDS added the core team [triage] Being looked at by the core Ghost team label Sep 17, 2025
Adding simplest possible store for only notes as the first step for migration. The store contains the following:
- byId - stores generalized notes by id
- lists - stores different lists rendering notes (e.g. feed, likes:index, profile:index etc)
- replaceList - adds first load of notes from the backend result to the store
- appendToList - appends following paginated notes to the store
- toggleLike - toggles like optimistically
This hook contains logic for mutation and invalidation for the like action. This helps separating backend endpoint logic from the store
Instead of mutating directly in FeedItemStats, it uses the newly added separate hook for the like action
It helps debugging what is added where in the store
This helps reducing the usage of frontend mapping for activity type for future migration. To make it possible to use the existing components, selectors convert Post -> Activity at the edge (single place)
@minimaluminium minimaluminium force-pushed the ap-zustand-notes-and-like-experiment branch from c5c5617 to 44b671c Compare October 13, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core team [triage] Being looked at by the core Ghost team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants