Skip to content

Added support for uploading GIFs to Notes#25370

Merged
sagzy merged 1 commit intomainfrom
gif-support
Nov 10, 2025
Merged

Added support for uploading GIFs to Notes#25370
sagzy merged 1 commit intomainfrom
gif-support

Conversation

@sagzy
Copy link
Contributor

@sagzy sagzy commented Nov 6, 2025

ref https://linear.app/ghost/issue/BER-2108


Note

Allows uploading GIF images in the New Note modal and bumps package version to 1.0.30.

  • Frontend:
    • New Note modal (apps/activitypub/src/components/modals/NewNoteModal.tsx): extend file input accept to include image/gif, enabling GIF uploads.
  • Package:
    • Bump @tryghost/activitypub version from 1.0.29 to 1.0.30 in apps/activitypub/package.json.

Written by Cursor Bugbot for commit b6656ab. This will update automatically on new commits. Configure here.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 6, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Two small changes in the ActivityPub package: the package version in apps/activitypub/package.json is bumped from 1.0.29 to 1.0.30, and the file input accept attribute in apps/activitypub/src/components/modals/NewNoteModal.tsx is extended to include image/gif (in addition to image/jpeg, image/png, and image/webp). No other fields, dependencies, logic, or control flow were modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Review files:
    • apps/activitypub/package.json — version bump only
    • apps/activitypub/src/components/modals/NewNoteModal.tsx — MIME type addition in accept attribute of file input

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: adding GIF upload support to Notes by extending file input accept attribute.
Description check ✅ Passed The description is related to the changeset, providing context about the GIF support addition and version bump with references to specific files.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch gif-support

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 79b6188a6427dfdfbf4bee4dc2a7eb84a3590207 and b6656ab.

📒 Files selected for processing (2)
  • apps/activitypub/package.json (1 hunks)
  • apps/activitypub/src/components/modals/NewNoteModal.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • apps/activitypub/src/components/modals/NewNoteModal.tsx
  • apps/activitypub/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Setup
  • GitHub Check: Setup
  • GitHub Check: Build & Push

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@sagzy sagzy merged commit 26dedc4 into main Nov 10, 2025
30 checks passed
@sagzy sagzy deleted the gif-support branch November 10, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants