Skip to content

Removed inactive topics in ActivityPub#25371

Merged
sagzy merged 1 commit intomainfrom
ap-remove-inactive-topics
Nov 6, 2025
Merged

Removed inactive topics in ActivityPub#25371
sagzy merged 1 commit intomainfrom
ap-remove-inactive-topics

Conversation

@minimaluminium
Copy link
Member

@minimaluminium minimaluminium commented Nov 6, 2025

no issues


Note

Removes several inactive topics from TopicFilter and bumps @tryghost/activitypub to 1.0.29.

  • ActivityPub
    • TopicFilter (src/components/TopicFilter.tsx):
      • Prunes topics: removes fashion-beauty, fiction, parenting, house-home from Topic type and TOPICS list.
    • Package:
      • Bumps version in apps/activitypub/package.json from 1.0.28 to 1.0.29.

Written by Cursor Bugbot for commit 73a7771. This will update automatically on new commits. Configure here.

@minimaluminium minimaluminium requested a review from sagzy November 6, 2025 11:20
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 6, 2025

Walkthrough

This PR makes two changes to the ActivityPub package: (1) bumps the package version from 1.0.28 to 1.0.29 in package.json, and (2) removes four topic options (fashion-beauty, fiction, parenting, house-home) from the TopicFilter component by updating both the exported Topic type definition and the TOPICS array.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify that no other components or modules reference the four removed topic values (fashion-beauty, fiction, parenting, house-home) elsewhere in the codebase
  • Confirm the Topic type updates are consistent with the TOPICS array entries
  • Check if any backend API logic or validation depends on these removed topic values
  • Ensure the UI renders correctly with the reduced set of topic options

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removing inactive topics from the ActivityPub component.
Description check ✅ Passed The description is related to the changeset, providing detailed information about the removed topics and version bump in the AI-generated summary.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ap-remove-inactive-topics

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0116267 and 73a7771.

📒 Files selected for processing (2)
  • apps/activitypub/package.json (1 hunks)
  • apps/activitypub/src/components/TopicFilter.tsx (2 hunks)
🧰 Additional context used
🧠 Learnings (4)
📚 Learning: 2025-03-13T09:00:20.205Z
Learnt from: mike182uk
Repo: TryGhost/Ghost PR: 22471
File: apps/admin-x-activitypub/src/utils/pending-activity.ts:13-71
Timestamp: 2025-03-13T09:00:20.205Z
Learning: The pending activity utilities in the Ghost ActivityPub module are covered by tests in the file `apps/admin-x-activitypub/test/unit/utils/pending-activity.ts`.

Applied to files:

  • apps/activitypub/package.json
📚 Learning: 2025-03-13T09:00:20.205Z
Learnt from: mike182uk
Repo: TryGhost/Ghost PR: 22471
File: apps/admin-x-activitypub/src/utils/pending-activity.ts:13-71
Timestamp: 2025-03-13T09:00:20.205Z
Learning: The pending activity utilities in Ghost's ActivityPub module are thoroughly tested in `apps/admin-x-activitypub/test/unit/utils/pending-activity.ts`, which covers `generatePendingActivityId`, `isPendingActivity`, and `generatePendingActivity` functions.

Applied to files:

  • apps/activitypub/package.json
📚 Learning: 2025-10-15T07:53:49.814Z
Learnt from: CR
Repo: TryGhost/Ghost PR: 0
File: apps/shade/AGENTS.md:0-0
Timestamp: 2025-10-15T07:53:49.814Z
Learning: Applies to apps/shade/**/*.{ts,tsx} : Use React + TypeScript and prefer composable components over heavy prop configurations

Applied to files:

  • apps/activitypub/src/components/TopicFilter.tsx
📚 Learning: 2025-10-15T07:53:49.814Z
Learnt from: CR
Repo: TryGhost/Ghost PR: 0
File: apps/shade/AGENTS.md:0-0
Timestamp: 2025-10-15T07:53:49.814Z
Learning: Applies to apps/shade/src/components/**/*.{tsx,ts} : Prefer compound subcomponents (e.g., Header.Title/Meta/Actions) with small focused parts attached as static properties and exported as named exports

Applied to files:

  • apps/activitypub/src/components/TopicFilter.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Setup
  • GitHub Check: Build & Push
  • GitHub Check: Setup
🔇 Additional comments (3)
apps/activitypub/src/components/TopicFilter.tsx (2)

6-32: LGTM: Topic type and TOPICS array are consistent.

The TOPICS array correctly reflects the updated Topic type definition. The removal of the four entries maintains the proper structure and typing.


4-4: No persisted data risks identified—this is a frontend-only UI component.

The removed topics have no references in the codebase outside of the TopicFilter component itself. The TopicFilter.tsx is a purely frontend React component used only for filtering display options in the activitypub app's inbox UI. No database schemas, migrations, fixtures, or seed data reference these topics, and the Topic type is not used in any backend or data persistence context.

apps/activitypub/package.json (1)

3-3: No breaking changes found — remove this review comment.

The search confirmed that removed topics ('fashion-beauty', 'fiction', 'parenting', 'house-home') are not referenced anywhere in the codebase. The package has internal consumers only (apps/admin), none of which depend on these topic values. A patch version bump (1.0.28 → 1.0.29) is appropriate for this change.

Likely an incorrect or invalid review comment.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sagzy sagzy merged commit 625800f into main Nov 6, 2025
31 checks passed
@sagzy sagzy deleted the ap-remove-inactive-topics branch November 6, 2025 12:56
abdultalha0862 pushed a commit to abdultalha0862/Ghost that referenced this pull request Nov 20, 2025
ref https://linear.app/ghost/issue/BER-2962

- a few discovery feed topics were low-volume and not bringing enough value, so we're removing them from the UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants