Skip to content

Added domains to blocked outbound refs#25379

Merged
9larsons merged 2 commits intomainfrom
upd-ref-blocklist
Nov 6, 2025
Merged

Added domains to blocked outbound refs#25379
9larsons merged 2 commits intomainfrom
upd-ref-blocklist

Conversation

@9larsons
Copy link
Contributor

@9larsons 9larsons commented Nov 6, 2025

ref https://linear.app/ghost/issue/ONC-1248/

Adding query params to 'old' site urls (particularly .html) tends to break a link when outbound link tagging is enabled. Occasionally we need to add a new domain to the list.


Note

Add bailii.org and www.bailii.org to the blocked outbound referrer domains list.

  • Member Attribution (backend):
    • Update blockedReferrerDomains in core/server/services/member-attribution/OutboundLinkTagger.js to include bailii.org and www.bailii.org.

Written by Cursor Bugbot for commit 77058cb. This will update automatically on new commits. Configure here.

@9larsons 9larsons enabled auto-merge (squash) November 6, 2025 17:00
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 6, 2025

Walkthrough

The change adds two domains (bailii.org and www.bailii.org) to the blockedReferrerDomains list in the OutboundLinkTagger.js file. This expands the set of referrer domains that are excluded from outbound link tagging, without modifying any control flow or business logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Simple list extension with no logic implications
  • No structural or functional changes to the codebase
  • Straightforward addition to an array/list of domain strings

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding domains to the blocked outbound referrer list.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description clearly explains the rationale and specifies the exact domains being added to the blocked referrer list.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch upd-ref-blocklist

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@9larsons 9larsons merged commit 32ef66c into main Nov 6, 2025
31 checks passed
@9larsons 9larsons deleted the upd-ref-blocklist branch November 6, 2025 17:22
abdultalha0862 pushed a commit to abdultalha0862/Ghost that referenced this pull request Nov 20, 2025
ref https://linear.app/ghost/issue/ONC-1248/

Adding query params to 'old' site urls (particularly .html) tends to
break a link when outbound link tagging is enabled. Occasionally we need
to add a new domain to the list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant