Skip to content

Fixed flaky post publish browser tests#25944

Merged
kevinansfield merged 1 commit intomainfrom
fix-flaky-post-publish-browser-tests
Jan 21, 2026
Merged

Fixed flaky post publish browser tests#25944
kevinansfield merged 1 commit intomainfrom
fix-flaky-post-publish-browser-tests

Conversation

@kevinansfield
Copy link
Copy Markdown
Member

no issue

  • we're seeing flaky browser tests when publishing posts where we can navigate away from the admin area to check for a published post before the publishing PUT request completes, causing an aborted request and a 404 for the post that never got published
  • added a wait for the "success" state of the save, indicated by the publish button no longer being visible so we're not navigating away to the frontend before the save request has completed

no issue

- we're seeing flaky browser tests when publishing posts where we can navigate away from the admin area to check for a published post before the publishing PUT request completes, causing an aborted request and a 404 for the post that never got published
- added a wait for the "success" state of the save, indicated by the publish button no longer being visible so we're not navigating away to the frontend before the save request has completed
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 21, 2026

Walkthrough

This change modifies an end-to-end browser test by replacing a placeholder comment with actual wait logic. After clicking the publish confirmation button, the test now explicitly waits for the confirm-publish button to become hidden before proceeding, ensuring the publish workflow completes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding a wait condition to fix flaky post publish browser tests by ensuring the publish request completes before navigation.
Description check ✅ Passed The description clearly explains the root cause of the flaky tests, the specific problem, and the solution implemented, all directly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kevinansfield kevinansfield enabled auto-merge (squash) January 21, 2026 20:58
@kevinansfield kevinansfield merged commit 4c6301e into main Jan 21, 2026
53 of 68 checks passed
@kevinansfield kevinansfield deleted the fix-flaky-post-publish-browser-tests branch January 21, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant