Fixed flaky post publish browser tests#25944
Merged
kevinansfield merged 1 commit intomainfrom Jan 21, 2026
Merged
Conversation
no issue - we're seeing flaky browser tests when publishing posts where we can navigate away from the admin area to check for a published post before the publishing PUT request completes, causing an aborted request and a 404 for the post that never got published - added a wait for the "success" state of the save, indicated by the publish button no longer being visible so we're not navigating away to the frontend before the save request has completed
Contributor
WalkthroughThis change modifies an end-to-end browser test by replacing a placeholder comment with actual wait logic. After clicking the publish confirmation button, the test now explicitly waits for the confirm-publish button to become hidden before proceeding, ensuring the publish workflow completes. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no issue