Newsletter preview dropdown #25963
Draft
Newsletter preview dropdown #25963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes https://linear.app/ghost/issue/DES-1274 When Stripe is not connected or there are no paid members, the member segment dropdown in the email preview now hides entirely when there's only one option. The dropdown remains visible on the web preview where there are multiple options. Co-authored-by: peter <peter@ghost.org>
|
Cursor Agent can help with this pull request. Just |
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Comment |
The segment dropdown is now hidden when there's only one option available, so the test now verifies this behavior instead of trying to interact with the dropdown. Co-authored-by: peter <peter@ghost.org>
Contributor
React E2E Tests FailedTo view the Playwright test report locally, run: REPORT_DIR=$(mktemp -d) && gh run download 21260901355 -n playwright-report-react -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got some code for us? Awesome 🎊!
Please take a minute to explain the change you're making:
To improve the user experience in the newsletter email preview. Currently, when there's only one member segment option (e.g., no paid members or Stripe not connected), the dropdown is still visible and clickable, which is redundant and can be confusing.
This change introduces a new computed property
showMemberSegmentDropdownthat controls the visibility of the member segment dropdown and its divider. The dropdown will now be hidden entirely in the email preview when only one member segment option is available, while remaining visible in the web preview or when multiple options exist.Ghost users will benefit from a cleaner and less confusing interface when composing newsletters, as redundant UI elements are removed. Developers will appreciate the more intuitive behavior of the preview modal.
Please check your PR against these items:
We appreciate your contribution! 🙏
Linear Issue: DES-1274