Fixed timezone bug in browser tests #25970
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test only change that shouldn't impact any user facing behavior.
Summary
Fixed a timezone-related flaky test failure in the publishing browser tests.
The Problem
The scheduling tests in
publishing.spec.jswere only settingtime: '00:00'without specifying a date. The assumption was that midnight today would always be in the past, triggering the auto-correction to "5 seconds in the future."However, this fails when the UTC date differs from the local date:
The Fix
Explicitly set
date: getTodayDateString()along withtime: '00:00'. The helper usesDateTime.now()to get the current system date, ensuring that "00:00 today" is always in the past regardless of timezone differences between the test runner and the server.Changes
getTodayDateString()helper function