-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
Switched back to using card checkout flow #26039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request introduces a new billing information update flow. It adds a new Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
Temporary change to make sure there's a full QA run of the feature before shipping.
409688a to
ea22ad4
Compare
lsinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compared with #25887 and looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@ghost/i18n/locales/fa/portal.json`:
- Line 85: The fa locale file has an empty value for the key "Failed to update
billing information, please try again" in portal.json; update that key's value
with a Persian translation (e.g. بهروزرسانی اطلاعات صورتحساب با خطا مواجه شد،
لطفاً دوباره تلاش کنید), making sure to replace the empty string with the
translated text and keep the JSON string quoting/escaping intact.
In `@ghost/i18n/locales/hu/portal.json`:
- Line 85: The Hungarian translation for the key "Failed to update billing
information, please try again" contains a double comma ("Kérjük,, próbáld
újra"); edit the value in portal.json to remove the extra comma so it reads
"Kérjük, próbáld újra" while keeping the rest of the string intact.
In `@ghost/i18n/locales/th/portal.json`:
- Line 85: Add the missing Thai translation for the key "Failed to update
billing information, please try again" in ghost/i18n/locales/th/portal.json by
replacing the empty string value with the provided Thai translation
"ไม่สามารถอัปเดตข้อมูลการเรียกเก็บเงินได้ โปรดลองอีกครั้ง" so the portal key
maps to the localized message.
🧹 Nitpick comments (1)
apps/portal/src/utils/api.js (1)
617-619: Redundant.catch()block.The
.catch(function (err) { throw err; })pattern simply rethrows the error without any transformation or logging. This is equivalent to not having the catch block at all.🔧 Suggested simplification
- }).catch(function (err) { - throw err; - }); + });Note: This pattern also exists in
manageBilling(lines 571-573), so you may want to address both for consistency.
| "Failed to sign up, please try again": "", | ||
| "Failed to update account data": "", | ||
| "Failed to update account details": "", | ||
| "Failed to update billing information, please try again": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provide a Persian translation for this new error message.
Line 85 is user-facing but currently empty, so the UI will likely fall back to English. Please add a localized value.
💬 Suggested translation
- "Failed to update billing information, please try again": "",
+ "Failed to update billing information, please try again": "بهروزرسانی اطلاعات صورتحساب ناموفق بود، لطفاً دوباره تلاش کنید",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "Failed to update billing information, please try again": "", | |
| "Failed to update billing information, please try again": "بهروزرسانی اطلاعات صورتحساب ناموفق بود، لطفاً دوباره تلاش کنید", |
🤖 Prompt for AI Agents
In `@ghost/i18n/locales/fa/portal.json` at line 85, The fa locale file has an
empty value for the key "Failed to update billing information, please try again"
in portal.json; update that key's value with a Persian translation (e.g.
بهروزرسانی اطلاعات صورتحساب با خطا مواجه شد، لطفاً دوباره تلاش کنید), making
sure to replace the empty string with the translated text and keep the JSON
string quoting/escaping intact.
| "Failed to sign up, please try again": "Nem sikerült a regisztráció. Kérjük, próbáld újra", | ||
| "Failed to update account data": "Nem sikerült frissíteni a fiókadatokat", | ||
| "Failed to update account details": "Nem sikerült frissíteni a fiókadatokat", | ||
| "Failed to update billing information, please try again": "Nem sikerült frissíteni a számlázási információkat. Kérjük, próbáld újra", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: Double comma in Hungarian translation.
There's a typographical error with a double comma: Kérjük,, should be Kérjük,.
Proposed fix
- "Failed to update billing information, please try again": "Nem sikerült frissíteni a számlázási információkat. Kérjük,, próbáld újra",
+ "Failed to update billing information, please try again": "Nem sikerült frissíteni a számlázási információkat. Kérjük, próbáld újra",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "Failed to update billing information, please try again": "Nem sikerült frissíteni a számlázási információkat. Kérjük, próbáld újra", | |
| "Failed to update billing information, please try again": "Nem sikerült frissíteni a számlázási információkat. Kérjük, próbáld újra", |
🤖 Prompt for AI Agents
In `@ghost/i18n/locales/hu/portal.json` at line 85, The Hungarian translation for
the key "Failed to update billing information, please try again" contains a
double comma ("Kérjük,, próbáld újra"); edit the value in portal.json to remove
the extra comma so it reads "Kérjük, próbáld újra" while keeping the rest of the
string intact.
| "Failed to sign up, please try again": "", | ||
| "Failed to update account data": "", | ||
| "Failed to update account details": "", | ||
| "Failed to update billing information, please try again": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing Thai translation for user-facing error message.
This new error message has an empty translation, meaning Thai users will see the English text when this error occurs. Consider providing a translation for a consistent localized experience.
Suggested translation:
"Failed to update billing information, please try again": "ไม่สามารถอัปเดตข้อมูลการเรียกเก็บเงินได้ โปรดลองอีกครั้ง"🤖 Prompt for AI Agents
In `@ghost/i18n/locales/th/portal.json` at line 85, Add the missing Thai
translation for the key "Failed to update billing information, please try again"
in ghost/i18n/locales/th/portal.json by replacing the empty string value with
the provided Thai translation "ไม่สามารถอัปเดตข้อมูลการเรียกเก็บเงินได้
โปรดลองอีกครั้ง" so the portal key maps to the localized message.
Temporary change to make sure there's a full QA run of the feature before shipping.