Updated next payment display for once offers#26065
Conversation
WalkthroughAdds an internal helper Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ref https://linear.app/ghost/issue/FEA-547 - Changed displayed label for once offers from "$5/month - Next payment" to "$5 - Next payment", following how Stripe renders the discounted price for once offers - Also added the corresponding i18n key
Changelog for v2.58.0 -> 2.58.1: - Updated i18n translations - 4529ad74b8
d781826 to
eb8ba4d
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@ghost/i18n/locales/de-CH/portal.json`:
- Around line 121-122: The JSON entry for the "Next payment" key currently has
an empty string; replace that empty value with the Swiss German translation
"Nächste Zahlung" so the de-CH locale shows a proper label (update the JSON
value for the "Next payment" key in portal.json accordingly).
| "Newsletters can be disabled on your account for two reasons: A previous email was marked as spam, or attempting to send an email resulted in a permanent failure (bounce).": "Newsletter können aus zwei Gründen in Ihrem Konto deaktiviert werden: Eine frühere E-Mail wurde als Spam markiert oder der Versuch, eine E-Mail zu senden, führte zu einem dauerhaften Fehler (Bounce).", | ||
| "Next payment": "", |
There was a problem hiding this comment.
Provide a de-CH translation instead of an empty string.
An empty value will likely display a blank label for German (Switzerland) users. Consider translating to “Nächste Zahlung” (Swiss German spelling uses no ß).
💡 Suggested translation
- "Next payment": "",
+ "Next payment": "Nächste Zahlung",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "Newsletters can be disabled on your account for two reasons: A previous email was marked as spam, or attempting to send an email resulted in a permanent failure (bounce).": "Newsletter können aus zwei Gründen in Ihrem Konto deaktiviert werden: Eine frühere E-Mail wurde als Spam markiert oder der Versuch, eine E-Mail zu senden, führte zu einem dauerhaften Fehler (Bounce).", | |
| "Next payment": "", | |
| "Newsletters can be disabled on your account for two reasons: A previous email was marked as spam, or attempting to send an email resulted in a permanent failure (bounce).": "Newsletter können aus zwei Gründen in Ihrem Konto deaktiviert werden: Eine frühere E-Mail wurde als Spam markiert oder der Versuch, eine E-Mail zu senden, führte zu einem dauerhaften Fehler (Bounce).", | |
| "Next payment": "Nächste Zahlung", |
🤖 Prompt for AI Agents
In `@ghost/i18n/locales/de-CH/portal.json` around lines 121 - 122, The JSON entry
for the "Next payment" key currently has an empty string; replace that empty
value with the Swiss German translation "Nächste Zahlung" so the de-CH locale
shows a proper label (update the JSON value for the "Next payment" key in
portal.json accordingly).
ref https://linear.app/ghost/issue/FEA-547