Fixed unclickable admin after closing user menu on mobile#26102
Fixed unclickable admin after closing user menu on mobile#26102kevinansfield merged 1 commit intomainfrom
Conversation
closes https://linear.app/ghost/issue/BER-3124/ - ref radix-ui/primitives#3317 - updated all `@radix-ui` dependency versions so we don't end up with multiple versions of sub-dependencies via yarn hoisting - multiple versions resulted in mismatched behaviour across popup dismissals that would leave a `pointer-events: none` style on the body element - removed `queueMicrotask` workarounds for the sticky pointer-events bug
WalkthroughThis pull request updates multiple Radix UI package dependencies across several applications and removes async workarounds from two component files. The Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26102 +/- ##
==========================================
+ Coverage 72.66% 72.67% +0.01%
==========================================
Files 1560 1561 +1
Lines 120151 120280 +129
Branches 14504 14521 +17
==========================================
+ Hits 87304 87419 +115
- Misses 31804 31838 +34
+ Partials 1043 1023 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…6102) closes https://linear.app/ghost/issue/BER-3124/ - ref radix-ui/primitives#3317 - updated all `@radix-ui` dependency versions so we don't end up with multiple versions of sub-dependencies via yarn hoisting - multiple versions resulted in mismatched behaviour across popup dismissals that would leave a `pointer-events: none` style on the body element - removed `queueMicrotask` workarounds for the sticky pointer-events bug
closes https://linear.app/ghost/issue/BER-3124/
@radix-uidependency versions so we don't end up with multiple versions of sub-dependencies via yarn hoistingpointer-events: nonestyle on the body elementqueueMicrotaskworkarounds for the sticky pointer-events bug