Skip to content

Fixed unclickable admin after closing user menu on mobile#26102

Merged
kevinansfield merged 1 commit intomainfrom
fix-stuck-body-pointerevents
Feb 2, 2026
Merged

Fixed unclickable admin after closing user menu on mobile#26102
kevinansfield merged 1 commit intomainfrom
fix-stuck-body-pointerevents

Conversation

@kevinansfield
Copy link
Copy Markdown
Member

closes https://linear.app/ghost/issue/BER-3124/

closes https://linear.app/ghost/issue/BER-3124/

- ref radix-ui/primitives#3317
- updated all `@radix-ui` dependency versions so we don't end up with multiple versions of sub-dependencies via yarn hoisting
  - multiple versions resulted in mismatched behaviour across popup dismissals that would leave a `pointer-events: none` style on the body element
- removed `queueMicrotask` workarounds for the sticky pointer-events bug
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 2, 2026

Walkthrough

This pull request updates multiple Radix UI package dependencies across several applications and removes async workarounds from two component files. The package.json files in apps/activitypub, apps/admin-x-design-system, and apps/shade receive version bumps for various Radix UI components. Additionally, the user-menu.tsx and comments-list.tsx files remove queueMicrotask wrapper calls in event handlers, replacing them with direct invocations of the target functions.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fixed unclickable admin after closing user menu on mobile' directly describes the main bug fix, which aligns with the primary objective of resolving the pointer-events issue that made the admin unclickable.
Description check ✅ Passed The description is directly related to the changeset, explaining the bug being fixed, the root cause (multiple Radix UI versions), the solution (updating dependencies and removing workarounds), and referencing the relevant issue.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-stuck-body-pointerevents

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.67%. Comparing base (5ca4eeb) to head (0c23405).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #26102      +/-   ##
==========================================
+ Coverage   72.66%   72.67%   +0.01%     
==========================================
  Files        1560     1561       +1     
  Lines      120151   120280     +129     
  Branches    14504    14521      +17     
==========================================
+ Hits        87304    87419     +115     
- Misses      31804    31838      +34     
+ Partials     1043     1023      -20     
Flag Coverage Δ
admin-tests 51.75% <ø> (-0.02%) ⬇️
e2e-tests 72.67% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kevinansfield kevinansfield merged commit 4fde815 into main Feb 2, 2026
39 checks passed
@kevinansfield kevinansfield deleted the fix-stuck-body-pointerevents branch February 2, 2026 15:37
betschki pushed a commit to magicpages/Ghost that referenced this pull request Feb 19, 2026
…6102)

closes https://linear.app/ghost/issue/BER-3124/

- ref radix-ui/primitives#3317
- updated all `@radix-ui` dependency versions so we don't end up with multiple versions of sub-dependencies via yarn hoisting
  - multiple versions resulted in mismatched behaviour across popup dismissals that would leave a `pointer-events: none` style on the body element
- removed `queueMicrotask` workarounds for the sticky pointer-events bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants