Skip to content

Conversation

@kevinansfield
Copy link
Member

@kevinansfield kevinansfield commented Feb 2, 2026

closes https://linear.app/ghost/issue/BER-3268/

  • the referral invite banner has never displayed correctly due to a typo in the admin/owner permissions check meaning it only worked if MRR stats were loaded outside of the component
  • since the old dashboard was replaced with the analytics dashboard in 6.0 the MRR stats haven't been loaded anywhere meaning the banner never displayed
  • removed both the banner and the now-unused dashboardStats service

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 2, 2026

📝 Walkthrough

Walkthrough

Removed the referral invite UI and its supporting dashboard statistics service, plus related tests and styling, eliminating referral banner/toast components, MRR loading logic, and dashboard-stats data layer across the admin codebase.

Changes

Cohort / File(s) Summary
Referral UI components
ghost/admin/app/components/gh-referral-invite.hbs, ghost/admin/app/components/gh-referral-invite.js
Deleted the referral invite component markup and its Ember component implementation (visibility logic, MRR loading, dismiss action).
Nav/footer banner
ghost/admin/app/components/gh-nav-menu/footer-banner.hbs, ghost/admin/app/components/gh-nav-menu/footer-banner.js, ghost/admin/app/components/gh-nav-menu/footer.hbs
Removed footer banner component and its invocation in the nav footer; removed banner markup, computed properties, constructor task, and dismiss action.
Dashboard statistics service
ghost/admin/app/services/dashboard-stats.js
Deleted entire DashboardStatsService: tracked properties, getters (e.g., currentMRR, memberCounts), all data-loading tasks, reload/fill helper logic, and public load methods.
Service tests
ghost/admin/tests/unit/services/dashboard-stats-test.js
Removed unit test suite for dashboard-stats service (existence, aggregation, filtering, attribution tests).
Styles
ghost/admin/app/styles/app-dark.css, ghost/admin/app/styles/layouts/main.css
Removed CSS rules related to referral/sidebar banner and referral toast close hover styles.

Poem

🐰 I nibbled code by moonlit beam,

a banner hopped out of the stream.
MRR and toasts tucked into ground,
Quiet sidebar, no more sound.
Hop — the admin path is clean and gleam.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main changes: removal of two unused components (GhReferralInvite and dashboardStats), which matches the changeset content.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove-ember-referral-invite

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

closes https://linear.app/ghost/issue/BER-3268/

- the referral invite banner has never displayed correctly due to a typo in the admin/owner permissions check meaning it only worked if MRR stats were loaded outside of the component
- since the old dashboard was replaced with the analytics dashboard in 6.0 the MRR stats haven't been loaded anywhere meaning the banner never displayed
- removed both the banner and the now-unused `dashboardStats` service
@kevinansfield kevinansfield force-pushed the remove-ember-referral-invite branch from a448f38 to a69faeb Compare February 2, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants