Add number formatting with thousands separators across apps#26306
Add number formatting with thousands separators across apps#26306JohnONolan wants to merge 1 commit intomainfrom
Conversation
- Added locale-aware number formatting to ActivityPub feed stats (likes, reposts, replies) - Added number formatting to comments UI like count - Added number formatting to pagination component - Added number formatting to history modal action counts - Added format-number helper to members filter count and import error counts https://claude.ai/code/session_01V1QqK2JgvNe5oQHt8st99e
WalkthroughThis pull request implements number formatting enhancements across multiple applications. Changes include adding locale-aware formatting to numeric displays in the ActivityPub feed components, pagination component, settings history modal, comments UI, and Ghost admin components. The modifications introduce formatting helpers and apply them to counts, statistics, and pagination indicators. These changes affect only the display presentation of numbers while preserving underlying logic and component functionality. Approximately seven files are modified with minimal line changes each. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Why are you making it?
Numbers throughout the Ghost admin and comment UI should be formatted with thousands separators (e.g., "1,234" instead of "1234") for improved readability, especially when displaying large counts like member imports, engagement metrics, and pagination totals.
What does it do?
This change adds consistent number formatting with thousands separators across multiple applications:
The implementation uses native
toLocaleString()for JavaScript and aformat-numberhelper for Handlebars templates, ensuring locale-appropriate formatting.Why is this something Ghost users or developers need?
Large numbers are difficult to parse at a glance. Adding thousands separators significantly improves the user experience when viewing statistics, pagination controls, and import results. This is a common UX best practice that makes the interface more professional and easier to use.
Checklist
https://claude.ai/code/session_01V1QqK2JgvNe5oQHt8st99e