Skip to content

Added explicit return type to oembed method#26650

Merged
EvanHahn merged 1 commit intomainfrom
unknownProvider-resolves-never
Mar 2, 2026
Merged

Added explicit return type to oembed method#26650
EvanHahn merged 1 commit intomainfrom
unknownProvider-resolves-never

Conversation

@EvanHahn
Copy link
Contributor

@EvanHahn EvanHahn commented Mar 2, 2026

no ref

This types-only change should have no user impact.

no ref

This types-only change should have no user impact.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1aa3c66 and 49b229b.

📒 Files selected for processing (1)
  • ghost/core/core/server/services/oembed/oembed-service.js

Walkthrough

The change updates JSDoc documentation in the OEmbed service by adding a @returns annotation to the unknownProvider method. This annotation specifies that the method returns Promise<never>, which indicates the promise never completes. No functional code changes were made to the method implementation.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding an explicit return type annotation to the unknownProvider method in the oembed service.
Description check ✅ Passed The description is related to the changeset, clearly stating it is a types-only change with no user impact, which aligns with the JSDoc annotation addition.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch unknownProvider-resolves-never

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EvanHahn EvanHahn merged commit 3e46be6 into main Mar 2, 2026
33 checks passed
@EvanHahn EvanHahn deleted the unknownProvider-resolves-never branch March 2, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant