Added instructions for bypassing mailpit with local dev#26657
Conversation
no ref - added yarn dev:mailgun script to bypass mailpit when needing to use a real service for testing trx emails
WalkthroughThis pull request adds Mailgun SMTP integration support for development environments. It introduces MAILGUN_SMTP_USER and MAILGUN_SMTP_PASS placeholders in the environment example file. A new Docker Compose configuration file (compose.dev.mailgun.yaml) is added, defining a Ghost service with Mailgun SMTP settings including transport protocol, host, port, and authentication credentials. Additionally, a new npm script dev:mailgun is introduced to enable running the development environment with this Mailgun-specific configuration. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
compose.dev.mailgun.yaml (1)
9-10: Use fail-fast variable expansion to catch missing SMTP credentials at startup.On lines 9-10, plain interpolation
${VAR}allows empty credentials and causes confusing runtime mail failures. Use Docker Compose's required-variable syntax so startup fails immediately with a clear error:- mail__options__auth__user: ${MAILGUN_SMTP_USER} - mail__options__auth__pass: ${MAILGUN_SMTP_PASS} + mail__options__auth__user: ${MAILGUN_SMTP_USER:?Set MAILGUN_SMTP_USER in .env} + mail__options__auth__pass: ${MAILGUN_SMTP_PASS:?Set MAILGUN_SMTP_PASS in .env}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@compose.dev.mailgun.yaml` around lines 9 - 10, Replace the plain variable interpolations for SMTP credentials with Docker Compose's required-variable syntax so the service fails fast on missing creds: change the mail__options__auth__user and mail__options__auth__pass values from ${MAILGUN_SMTP_USER} and ${MAILGUN_SMTP_PASS} to the required form (e.g., ${MAILGUN_SMTP_USER:?MAILGUN_SMTP_USER required} and ${MAILGUN_SMTP_PASS:?MAILGUN_SMTP_PASS required}) so startup errors clearly if either is unset.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@compose.dev.mailgun.yaml`:
- Around line 9-10: Replace the plain variable interpolations for SMTP
credentials with Docker Compose's required-variable syntax so the service fails
fast on missing creds: change the mail__options__auth__user and
mail__options__auth__pass values from ${MAILGUN_SMTP_USER} and
${MAILGUN_SMTP_PASS} to the required form (e.g.,
${MAILGUN_SMTP_USER:?MAILGUN_SMTP_USER required} and
${MAILGUN_SMTP_PASS:?MAILGUN_SMTP_PASS required}) so startup errors clearly if
either is unset.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26657 +/- ##
=======================================
Coverage 73.24% 73.24%
=======================================
Files 1528 1528
Lines 120335 120335
Branches 14544 14544
=======================================
Hits 88134 88134
- Misses 31182 31198 +16
+ Partials 1019 1003 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
no ref