Enabled pintura image editing in welcome email editor#26695
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughA new hook 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/admin-x-framework/src/hooks/use-pintura-config.ts`:
- Line 24: The hostPintura value is read from the wrong path; change the access
from config?.pintura to config?.hostSettings?.pintura so host-provided Pintura
URLs are picked up. Update the assignment in use-pintura-config (the hostPintura
declaration) to use the nested hostSettings property and keep the same type
assertion ({ js?: string; css?: string } | undefined) to match the Config type.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 681c67ec-2c31-443f-868a-d397a1722b56
📒 Files selected for processing (3)
apps/admin-x-framework/src/hooks.tsapps/admin-x-framework/src/hooks/use-pintura-config.tsapps/admin-x-settings/src/components/settings/membership/member-emails/member-email-editor.tsx
|
I'm going to take over this PR and get it merged. |
closes https://linear.app/ghost/issue/NY-1125
usePinturaConfighook to admin