Conversation
no ref Node can natively run TypeScript files, but only if they have "erasable syntax". This means it can't handle things like enums and namespaces. This enforces that in the `@tryghost/parse-email-address` package.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA new TypeScript compiler option 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
no ref
Node can natively run TypeScript files, but only if they have "erasable syntax". This means it can't handle things like enums and namespaces.
This enforces that in the
@tryghost/parse-email-addresspackage.Note
Low Risk
Build-time TypeScript configuration change only; main risk is new compilation errors if the package uses non-erasable TS constructs (e.g., enums/namespaces).
Overview
Adds
"erasableSyntaxOnly": truetoghost/parse-email-address/tsconfig.json, enforcing that the package’s TypeScript uses only syntax Node can erase when running TS natively.This tightens the compiler constraints and will cause the build to fail if
@tryghost/parse-email-addressintroduces non-erasable constructs (e.g.,enum,namespace) going forward.Written by Cursor Bugbot for commit 841bb6a. This will update automatically on new commits. Configure here.