Skip to content

Fixed divider color in member welcome email#26704

Merged
9larsons merged 1 commit intomainfrom
fix-email-divider
Mar 4, 2026
Merged

Fixed divider color in member welcome email#26704
9larsons merged 1 commit intomainfrom
fix-email-divider

Conversation

@9larsons
Copy link
Copy Markdown
Contributor

@9larsons 9larsons commented Mar 4, 2026

@9larsons 9larsons enabled auto-merge (squash) March 4, 2026 18:42
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8dd3410a-90d6-472f-9879-ff0ad9d10a61

📥 Commits

Reviewing files that changed from the base of the PR and between 895aa01 and e73c7a3.

📒 Files selected for processing (2)
  • ghost/core/core/server/services/member-welcome-emails/email-templates/wrapper.hbs
  • ghost/core/core/server/services/member-welcome-emails/member-welcome-email-renderer.js

Walkthrough

The changes make the divider color in the member welcome email template configurable. Three hard-coded border color references (#EEF5F8) in the wrapper template are replaced with a templated variable ({{dividerColor}}). The member welcome email renderer is updated to provide this variable with a value of #e0e7eb when rendering the email. No control flow, logic, or error handling modifications are introduced.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing divider color in the member welcome email template by replacing hard-coded values with a templated variable.
Description check ✅ Passed The description provides a reference to the related linear issue (NY-1126), which is related to the changeset about fixing the divider color in member welcome emails.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-email-divider

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@9larsons 9larsons merged commit 731ea2f into main Mar 4, 2026
33 checks passed
@9larsons 9larsons deleted the fix-email-divider branch March 4, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants